From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NhHJ3-0001PB-J3
	for qemu-devel@nongnu.org; Tue, 16 Feb 2010 01:53:13 -0500
Received: from [199.232.76.173] (port=36416 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NhHJ2-0001Ov-Cs
	for qemu-devel@nongnu.org; Tue, 16 Feb 2010 01:53:12 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <av1474@comtv.ru>) id 1NhHJ0-0008Go-SE
	for qemu-devel@nongnu.org; Tue, 16 Feb 2010 01:53:12 -0500
Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:57785 helo=akado.ru)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <av1474@comtv.ru>) id 1NhHJ0-0008GQ-F6
	for qemu-devel@nongnu.org; Tue, 16 Feb 2010 01:53:10 -0500
Date: Tue, 16 Feb 2010 09:52:50 +0300 (MSK)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host
	ppc_init_cacheline_sizes() implementation.
In-Reply-To: <20100215224004.GA29604@triton8.kn-bremen.de>
Message-ID: <alpine.LNX.2.00.1002160951360.1456@linmac>
References: <20100214201056.GA97858@triton8.kn-bremen.de>
	<20100214201209.GA97896@triton8.kn-bremen.de>
	<alpine.LNX.2.00.1002150615430.1532@linmac>
	<20100215224004.GA29604@triton8.kn-bremen.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juergen Lock <nox@jelal.kn-bremen.de>
Cc: qemu-devel@nongnu.org

On Mon, 15 Feb 2010, Juergen Lock wrote:

> On Mon, Feb 15, 2010 at 06:16:07AM +0300, malc wrote:
> > On Sun, 14 Feb 2010, Juergen Lock wrote:
> > 
> > > Submitted by: Andreas Tobler <andreast@fgznet.ch>
> > > 
> > > Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
> > > 
> > > --- a/cache-utils.c
> > > +++ b/cache-utils.c
> > > @@ -57,6 +57,23 @@
> > >  }
> > >  #endif
> > >  
> > > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> > 
> > __FreeBSD_kernel__ is for something like Debian/kFreeBSD?
> 
> Yep, it is.  Support for it was added to qemu some time ago so I
> figured I should do the same.
> 

Perhaps it would be better to avoid this particular ifdefery and
just go with _CALL_SYSV, can you verify that:

~$ gcc -E -dM -x c /dev/null | grep SYSV

yields

#define _CALL_SYSV 1

on FreeBSD and Debian/kFreeBSD?

-- 
mailto:av1474@comtv.ru