* [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set
@ 2010-03-04 12:09 malc
2010-03-04 13:03 ` malc
0 siblings, 1 reply; 3+ messages in thread
From: malc @ 2010-03-04 12:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Brad Spengler
Signed-off-by: malc <av1474@comtv.ru>
---
target-i386/translate.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index a597e80..68e6df9 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -4589,9 +4589,7 @@ static target_ulong disas_insn(DisasContext *s,
target_ulong pc_start)
/* operand size for jumps is 64 bit */
ot = OT_QUAD;
} else if (op == 3 || op == 5) {
- /* for call calls, the operand is 16 or 32 bit, even
- in long mode */
- ot = dflag ? OT_LONG : OT_WORD;
+ ot = dflag ? OT_LONG + (rex_w == 1) : OT_WORD;
} else if (op == 6) {
/* default push size is 64 bit */
ot = dflag ? OT_QUAD : OT_WORD;
--
1.6.6.1
--
mailto:av1474@comtv.ru
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set
2010-03-04 12:09 [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set malc
@ 2010-03-04 13:03 ` malc
2010-03-06 18:21 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: malc @ 2010-03-04 13:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Brad Spengler
On Thu, 4 Mar 2010, malc wrote:
That's not enough, later on there's a bunch of operations assuming
32bit width...
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set
2010-03-04 13:03 ` malc
@ 2010-03-06 18:21 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-03-06 18:21 UTC (permalink / raw)
To: malc; +Cc: Brad Spengler, qemu-devel
On Thu, Mar 04, 2010 at 04:03:33PM +0300, malc wrote:
> On Thu, 4 Mar 2010, malc wrote:
>
> That's not enough, later on there's a bunch of operations assuming
> 32bit width...
>
After discussing with malc, it happens that this patch is actually
correct and enough. I have just committed it.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-06 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-04 12:09 [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set malc
2010-03-04 13:03 ` malc
2010-03-06 18:21 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).