From: malc <av1474@comtv.ru>
To: Andreas Tobler <andreast@fgznet.ch>
Cc: Juergen Lock <nox@jelal.kn-bremen.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes
Date: Sat, 13 Mar 2010 01:13:34 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.00.1003130113250.5945@linmac> (raw)
In-Reply-To: <4B9ABB1F.7010906@fgznet.ch>
On Fri, 12 Mar 2010, Andreas Tobler wrote:
> On 12.03.10 22:59, malc wrote:
> > On Fri, 12 Mar 2010, Juergen Lock wrote:
> >
> > > This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b.
> > > (The bug was mine actually...)
> > >
> > > Submitted by: Andreas Tobler<andreast@fgznet.ch>
> > >
> > > Signed-off-by: Juergen Lock<nox@jelal.kn-bremen.de>
> > >
> > > --- a/cache-utils.c
> > > +++ b/cache-utils.c
> > > @@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi
> > > #endif
> > >
> > > #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> > > +#include<errno.h>
> > > #include<stdio.h>
> > > +#include<stdlib.h>
> >
> > And stdlib is needed for what exactly?
>
> To avoid this one:
>
> cache-utils.c: In function 'ppc_init_cacheline_sizes':
> cache-utils.c:76: warning: implicit declaration of function 'exit'
Ok, right you are.
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2010-03-12 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 21:50 [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes Juergen Lock
2010-03-12 21:59 ` malc
2010-03-12 22:07 ` Andreas Tobler
2010-03-12 22:13 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1003130113250.5945@linmac \
--to=av1474@comtv.ru \
--cc=andreast@fgznet.ch \
--cc=nox@jelal.kn-bremen.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).