* [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes
@ 2010-03-12 21:50 Juergen Lock
2010-03-12 21:59 ` malc
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Lock @ 2010-03-12 21:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Tobler
This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b.
(The bug was mine actually...)
Submitted by: Andreas Tobler <andreast@fgznet.ch>
Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
--- a/cache-utils.c
+++ b/cache-utils.c
@@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi
#endif
#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
+#include <errno.h>
#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
#include <sys/types.h>
#include <sys/sysctl.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes
2010-03-12 21:50 [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes Juergen Lock
@ 2010-03-12 21:59 ` malc
2010-03-12 22:07 ` Andreas Tobler
0 siblings, 1 reply; 4+ messages in thread
From: malc @ 2010-03-12 21:59 UTC (permalink / raw)
To: Juergen Lock; +Cc: qemu-devel, Andreas Tobler
On Fri, 12 Mar 2010, Juergen Lock wrote:
> This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b.
> (The bug was mine actually...)
>
> Submitted by: Andreas Tobler <andreast@fgznet.ch>
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
> --- a/cache-utils.c
> +++ b/cache-utils.c
> @@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi
> #endif
>
> #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> +#include <errno.h>
> #include <stdio.h>
> +#include <stdlib.h>
And stdlib is needed for what exactly?
> +#include <string.h>
> #include <sys/types.h>
> #include <sys/sysctl.h>
>
>
>
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes
2010-03-12 21:59 ` malc
@ 2010-03-12 22:07 ` Andreas Tobler
2010-03-12 22:13 ` malc
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Tobler @ 2010-03-12 22:07 UTC (permalink / raw)
To: malc; +Cc: Juergen Lock, qemu-devel
On 12.03.10 22:59, malc wrote:
> On Fri, 12 Mar 2010, Juergen Lock wrote:
>
>> This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b.
>> (The bug was mine actually...)
>>
>> Submitted by: Andreas Tobler<andreast@fgznet.ch>
>>
>> Signed-off-by: Juergen Lock<nox@jelal.kn-bremen.de>
>>
>> --- a/cache-utils.c
>> +++ b/cache-utils.c
>> @@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi
>> #endif
>>
>> #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
>> +#include<errno.h>
>> #include<stdio.h>
>> +#include<stdlib.h>
>
> And stdlib is needed for what exactly?
To avoid this one:
cache-utils.c: In function 'ppc_init_cacheline_sizes':
cache-utils.c:76: warning: implicit declaration of function 'exit'
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes
2010-03-12 22:07 ` Andreas Tobler
@ 2010-03-12 22:13 ` malc
0 siblings, 0 replies; 4+ messages in thread
From: malc @ 2010-03-12 22:13 UTC (permalink / raw)
To: Andreas Tobler; +Cc: Juergen Lock, qemu-devel
On Fri, 12 Mar 2010, Andreas Tobler wrote:
> On 12.03.10 22:59, malc wrote:
> > On Fri, 12 Mar 2010, Juergen Lock wrote:
> >
> > > This fixes commit e4ee916d3f9a93df06bd498c92767c1558d59a0b.
> > > (The bug was mine actually...)
> > >
> > > Submitted by: Andreas Tobler<andreast@fgznet.ch>
> > >
> > > Signed-off-by: Juergen Lock<nox@jelal.kn-bremen.de>
> > >
> > > --- a/cache-utils.c
> > > +++ b/cache-utils.c
> > > @@ -58,7 +58,10 @@ static void ppc_init_cacheline_sizes(voi
> > > #endif
> > >
> > > #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> > > +#include<errno.h>
> > > #include<stdio.h>
> > > +#include<stdlib.h>
> >
> > And stdlib is needed for what exactly?
>
> To avoid this one:
>
> cache-utils.c: In function 'ppc_init_cacheline_sizes':
> cache-utils.c:76: warning: implicit declaration of function 'exit'
Ok, right you are.
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-12 22:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-12 21:50 [Qemu-devel] [PATCH] FreeBSD ppc_init_cacheline_sizes(): add missing #includes Juergen Lock
2010-03-12 21:59 ` malc
2010-03-12 22:07 ` Andreas Tobler
2010-03-12 22:13 ` malc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).