From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzCMo-0003H9-7Q
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 13:15:10 -0400
Received: from [140.186.70.92] (port=54952 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzCMm-0003GS-OR
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 13:15:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1NzCMl-0007fW-Ap
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 13:15:08 -0400
Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:60416 helo=akado.ru)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1NzCMl-0007fQ-23
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 13:15:07 -0400
Date: Tue, 6 Apr 2010 21:14:54 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host
	TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions.
In-Reply-To: <74849C04-AC64-4CAD-BA29-419D161EE8D6@web.de>
Message-ID: <alpine.LNX.2.00.1004062114400.1881@linmac>
References: <20100214201056.GA97858@triton8.kn-bremen.de>
	<20100214201331.GB97913@triton8.kn-bremen.de>
	<20100216211414.GA81084@triton8.kn-bremen.de>
	<74849C04-AC64-4CAD-BA29-419D161EE8D6@web.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Juergen Lock <nox@jelal.kn-bremen.de>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, 6 Apr 2010, Andreas F?rber wrote:

> 
> Am 16.02.2010 um 22:14 schrieb Juergen Lock:
> 
> > On Sun, Feb 14, 2010 at 09:13:31PM +0100, Juergen Lock wrote:
> > > Submitted by: Andreas Tobler <andreast@fgznet.ch>
> > > 
> > > Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
> > > 
> > > --- a/tcg/ppc/tcg-target.h
> > > +++ b/tcg/ppc/tcg-target.h
> > > @@ -69,7 +69,7 @@
> > > #define TCG_TARGET_CALL_STACK_OFFSET 24
> > > #elif defined _AIX
> > > #define TCG_TARGET_CALL_STACK_OFFSET 52
> > > -#elif defined __linux__
> > > +#elif defined __linux__ || defined __FreeBSD__ ||
> > > defined(__FreeBSD_kernel__)
> > > #define TCG_TARGET_CALL_ALIGN_ARGS 1
> > > #define TCG_TARGET_CALL_STACK_OFFSET 8
> > > #else
> > 
> > New version using ppc _CALL_* definitions after malc's comments:
> > 
> > Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
> > 
> > --- a/tcg/ppc/tcg-target.h
> > +++ b/tcg/ppc/tcg-target.h
> > @@ -65,11 +65,11 @@ enum {
> > /* used for function call generation */
> > #define TCG_REG_CALL_STACK TCG_REG_R1
> > #define TCG_TARGET_STACK_ALIGN 16
> > -#if defined __APPLE__
> > +#if defined _CALL_DARWIN
> > #define TCG_TARGET_CALL_STACK_OFFSET 24
> 
> 5da79c86a3744e3a901c7986c109dd06951befd2 broke compilation on Mac OS X v10.5
> ppc: Apparently _CALL_DARWIN is not defined, so it runs into the #else.

Which gcc version?

> 
> Andreas
> 
> > -#elif defined _AIX
> > +#elif defined _CALL_AIX
> > #define TCG_TARGET_CALL_STACK_OFFSET 52
> > -#elif defined __linux__
> > +#elif defined _CALL_SYSV
> > #define TCG_TARGET_CALL_ALIGN_ARGS 1
> > #define TCG_TARGET_CALL_STACK_OFFSET 8
> > #else
> > 
> 

-- 
mailto:av1474@comtv.ru