From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35745 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYv8U-0002Sq-3Z for qemu-devel@nongnu.org; Wed, 14 Jul 2010 02:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYv8S-0002hu-Uh for qemu-devel@nongnu.org; Wed, 14 Jul 2010 02:08:01 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:61839 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYv8S-0002gZ-NP for qemu-devel@nongnu.org; Wed, 14 Jul 2010 02:08:00 -0400 Date: Wed, 14 Jul 2010 10:07:20 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer In-Reply-To: <1279086307-9596-2-git-send-email-eduard.munteanu@linux360.ro> Message-ID: References: <1279086307-9596-1-git-send-email-eduard.munteanu@linux360.ro> <1279086307-9596-2-git-send-email-eduard.munteanu@linux360.ro> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduard - Gabriel Munteanu Cc: joro@8bytes.org, paul@codesourcery.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote: > This provides an API for abstracting IOMMU functions. Hardware emulation > code can use it to request address translation and access checking. In > the absence of an emulated IOMMU, no translation/checking happens and > I/O goes through as before. > > IOMMU emulation code must provide implementation-specific hooks for this > layer. > [..snip..] > +int __iommu_rw(struct iommu *iommu, > + DeviceState *dev, > + target_phys_addr_t addr, > + uint8_t *buf, > + int len, > + int is_write) Do not use leading double underscore. [..snip..] -- mailto:av1474@comtv.ru