From: malc <av1474@comtv.ru>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)
Date: Tue, 27 Jul 2010 22:51:20 +0400 (MSD) [thread overview]
Message-ID: <alpine.LNX.2.00.1007272249500.6551@linmac> (raw)
In-Reply-To: <20100727183539.GN16655@random.random>
On Tue, 27 Jul 2010, Andrea Arcangeli wrote:
> On Tue, Jul 27, 2010 at 01:24:12PM -0500, Anthony Liguori wrote:
> > On 07/27/2010 01:15 PM, Andrea Arcangeli wrote:
> > > On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote:
> > >
> > >> printf()s?
> > >>
> > > I see plenty of printf in that file, do you want them only under
> > > #ifdef DEBUG_IDE?
> > >
> >
> > Yes.
>
> Indented with 4 spaces too, but there are tabs, hope that's ok
> otherwise I need to undo my editor settings optimized for kernel
> (develock has quite an opinion on the tab/space issue ;).
No, it's not okay. Unfortunatelly when i hexdump -Ced previous
submission the presence of tabs escaped me, sorry.
[..snip..]
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-07-27 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 17:30 [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4) Andrea Arcangeli
2010-07-27 17:44 ` Anthony Liguori
2010-07-27 18:15 ` Andrea Arcangeli
2010-07-27 18:24 ` Anthony Liguori
2010-07-27 18:35 ` Andrea Arcangeli
2010-07-27 18:41 ` Anthony Liguori
2010-07-27 19:04 ` Andrea Arcangeli
2010-07-30 8:02 ` Kevin Wolf
2010-07-27 18:51 ` malc [this message]
2010-07-27 18:05 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1007272249500.6551@linmac \
--to=av1474@comtv.ru \
--cc=aarcange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).