From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46360 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdpG1-0007Q0-FU for qemu-devel@nongnu.org; Tue, 27 Jul 2010 14:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdpFz-0008LJ-8R for qemu-devel@nongnu.org; Tue, 27 Jul 2010 14:52:04 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:53160 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdpFy-0008Kz-Vg for qemu-devel@nongnu.org; Tue, 27 Jul 2010 14:52:03 -0400 Date: Tue, 27 Jul 2010 22:51:20 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4) In-Reply-To: <20100727183539.GN16655@random.random> Message-ID: References: <20100727173050.GK16655@random.random> <4C4F1AFB.3020100@codemonkey.ws> <20100727181522.GM16655@random.random> <4C4F244C.90906@codemonkey.ws> <20100727183539.GN16655@random.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrea Arcangeli Cc: qemu-devel@nongnu.org On Tue, 27 Jul 2010, Andrea Arcangeli wrote: > On Tue, Jul 27, 2010 at 01:24:12PM -0500, Anthony Liguori wrote: > > On 07/27/2010 01:15 PM, Andrea Arcangeli wrote: > > > On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: > > > > > >> printf()s? > > >> > > > I see plenty of printf in that file, do you want them only under > > > #ifdef DEBUG_IDE? > > > > > > > Yes. > > Indented with 4 spaces too, but there are tabs, hope that's ok > otherwise I need to undo my editor settings optimized for kernel > (develock has quite an opinion on the tab/space issue ;). No, it's not okay. Unfortunatelly when i hexdump -Ced previous submission the presence of tabs escaped me, sorry. [..snip..] -- mailto:av1474@comtv.ru