From: malc <av1474@comtv.ru>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule
Date: Sun, 1 Aug 2010 00:35:12 +0400 (MSD) [thread overview]
Message-ID: <alpine.LNX.2.00.1008010030360.2706@linmac> (raw)
In-Reply-To: <AANLkTi=Bs0eegcR2C3=dNd=VZ7Zz-a2N+hj-uBAXN+09@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1099 bytes --]
On Sat, 31 Jul 2010, Blue Swirl wrote:
> On Sat, Jul 31, 2010 at 4:23 PM, malc <av1474@comtv.ru> wrote:
> > History has shown that this particular rule is unenforcable.
> >
> > Signed-off-by: malc <av1474@comtv.ru>
> > ---
> > CODING_STYLE | 11 ++++++-----
> > 1 files changed, 6 insertions(+), 5 deletions(-)
>
> Not again:
> http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg00484.html
I'm not yet senile enough to forget that, let me quote some:
"By picking a single coding style we've pretty much guaranteed that most
people will disagree with some of it. IMO consistency is more important."
We don't have consistency, people, myself included (which was a suprise),
keep applying patches that break things in this particular regard, it
should just go.
>
> There are plenty of ways to make the rule enforceable, for example we
> could agree to start to revert commits which introduce new
> CODING_STYLE violations.
>
There might be plenty of ways, but none were/are used, we somehow
managed to enforce tab rule, but the braces remain elusive.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-07-31 20:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 16:23 [Qemu-devel] [PATCH] Drop braces around single statement rule malc
2010-07-31 16:47 ` Aurelien Jarno
2010-07-31 16:51 ` Aurelien Jarno
2010-07-31 20:23 ` Blue Swirl
2010-07-31 20:35 ` malc [this message]
2010-07-31 23:49 ` Aurelien Jarno
2010-08-02 15:20 ` Anthony Liguori
2010-08-02 15:41 ` Kevin Wolf
2010-08-02 15:48 ` Anthony Liguori
2010-08-02 16:06 ` malc
2010-08-02 16:18 ` Anthony Liguori
2010-08-02 16:29 ` Blue Swirl
2010-08-02 16:32 ` Anthony Liguori
2010-08-02 15:55 ` malc
2010-08-02 16:04 ` Anthony Liguori
2010-08-02 16:24 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1008010030360.2706@linmac \
--to=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).