From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59404 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfIml-0007JE-BU for qemu-devel@nongnu.org; Sat, 31 Jul 2010 16:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfImj-00067z-Tq for qemu-devel@nongnu.org; Sat, 31 Jul 2010 16:35:59 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:60016 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfImj-00067S-N0 for qemu-devel@nongnu.org; Sat, 31 Jul 2010 16:35:57 -0400 Date: Sun, 1 Aug 2010 00:35:12 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule In-Reply-To: Message-ID: References: <1280593414-2232-1-git-send-email-av1474@comtv.ru> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="33734824-309631782-1280608514=:2706" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --33734824-309631782-1280608514=:2706 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 31 Jul 2010, Blue Swirl wrote: > On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > >  CODING_STYLE |   11 ++++++----- > >  1 files changed, 6 insertions(+), 5 deletions(-) > > Not again: > http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg00484.html I'm not yet senile enough to forget that, let me quote some: "By picking a single coding style we've pretty much guaranteed that most people will disagree with some of it. IMO consistency is more important." We don't have consistency, people, myself included (which was a suprise), keep applying patches that break things in this particular regard, it should just go. > > There are plenty of ways to make the rule enforceable, for example we > could agree to start to revert commits which introduce new > CODING_STYLE violations. > There might be plenty of ways, but none were/are used, we somehow managed to enforce tab rule, but the braces remain elusive. -- mailto:av1474@comtv.ru --33734824-309631782-1280608514=:2706--