From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59360 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfxMr-0005l2-FU for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfxMp-0006WV-Uz for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:55:57 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:53668 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfxMp-0006U9-OE for qemu-devel@nongnu.org; Mon, 02 Aug 2010 11:55:55 -0400 Date: Mon, 2 Aug 2010 19:55:04 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule In-Reply-To: <4C56E732.7060102@redhat.com> Message-ID: References: <1280593414-2232-1-git-send-email-av1474@comtv.ru> <20100731234956.GJ31640@hall.aurel32.net> <4C56E253.7010403@codemonkey.ws> <4C56E732.7060102@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Blue Swirl , Aurelien Jarno , qemu-devel@nongnu.org On Mon, 2 Aug 2010, Kevin Wolf wrote: > Am 02.08.2010 17:20, schrieb Anthony Liguori: > > On 07/31/2010 06:49 PM, Aurelien Jarno wrote: > >> On Sat, Jul 31, 2010 at 08:23:55PM +0000, Blue Swirl wrote: [..snip..] > > > So really, I think the problem is that we're enforcing the words of > > CODING_STYLE instead of the intent. The intent of CODING_STYLE is to > > improve the readability of the code. I think it requires a certain > > amount of taste to be applied. > > > Rejecting a big patch because braces aren't used in single line if > > statements seems to be an unnecessary barrier to me. > > Taking such patches anyway is basically what we're doing today, right? > And what malc is complaining about. Malc is mainly complaining about "Quod licet Jovi non licet bovi" situation. -- mailto:av1474@comtv.ru