From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39994 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfxYF-0001Om-5x for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfxY7-0000tf-OR for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:07:38 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:59272 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfxY7-0000t1-H6 for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:07:35 -0400 Date: Mon, 2 Aug 2010 20:06:46 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule In-Reply-To: <4C56E8CB.1090104@codemonkey.ws> Message-ID: References: <1280593414-2232-1-git-send-email-av1474@comtv.ru> <20100731234956.GJ31640@hall.aurel32.net> <4C56E253.7010403@codemonkey.ws> <4C56E732.7060102@redhat.com> <4C56E8CB.1090104@codemonkey.ws> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno On Mon, 2 Aug 2010, Anthony Liguori wrote: > On 08/02/2010 10:41 AM, Kevin Wolf wrote: > > > > > But something like braces around an if doesn't seem like it creates a > > > big problem. Most C programmers are used to seeing braces in some > > > statements and not other. Therefore, it's hard to argue that the code > > > gets really unreadable if this isn't strictly enforced. > > > > > I won't argue that missing braces impact readability of the code, they > > probably don't. However, as was pointed out in earlier discussion there > > still remain two important points: > > > > 1. While it doesn't make a difference for the code itself, readability > > of patches suffers when braces have to be added/removed when a second > > line is inserted or disappears. > > > > I understand the argument but it's not something that I strongly agree with. > > > 2. I've messed up more than once with adding some debug code (even worse > > when it happens with real code): > > > > if (foo) > > fprintf(stderr, "debug msg\n"); > > bar(); /* oops, not conditional any more */ > > > > This is hard to do with editors that auto indent unless you're copying and > pasting debugging. And yeah, I've made that mistake too doing the later :-) > > > This is why I tend to disagree with removing the rule, and suggest to > > rather implement some automatic checks like Aurelien suggested (if we > > need to change anything at all). I usually don't ask for a respin just > > for braces if the patch is good otherwise, but if you think we should > > just reject such patches without exceptions, I can change that. > > > > Yeah, I try to remember to enforce it but often forget or just don't notice. > My eyes don't tend to catch missing braces like they would catch bad type > naming because the former is really not uncommon. > > I'm happy with the status quo but I won't object to a git commit hook that > enforces style. Seriously? You are happy with the situation where some people get their patches rejected because they disagree/forogot/don't_care about single statement braces while the patches of others make it through? -- mailto:av1474@comtv.ru