Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[malc <av1474@comtv.ru>]

On Thu, 12 Aug 2010, Blue Swirl wrote:

> Add a few rules, based loosely on libvirt HACKING.
> 
> Blue Swirl (5):
>   CODING_STYLE: add preprocessor rules
>   CODING_STYLE: add C type rules
>   CODING_STYLE: add memory management rules
>   CODING_STYLE: add string management rules
>   CODING_STYLE: add rules for printf-like functions
> 
>  CODING_STYLE |  111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 111 insertions(+), 0 deletions(-)

While intentions of this are good, i believe this goes too far, i doubt
that the proposed additions are enforcable and have no doubts that they
will be widely ignored and at the same time provide more grounds for
whining. Furthermore the existing code doesn't follow them, going out on
a limb, it's more likely that one would look around the code he/she
modifies and base his/her modifications on the surrounding code than to
follow the style that conflicts with it.

-- 
mailto:av1474@comtv.ru