From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44182 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjcxU-0005vd-9Z for qemu-devel@nongnu.org; Thu, 12 Aug 2010 14:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjcxF-0003yW-OV for qemu-devel@nongnu.org; Thu, 12 Aug 2010 14:56:44 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:61935 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjcxF-0003y9-Hy for qemu-devel@nongnu.org; Thu, 12 Aug 2010 14:56:41 -0400 Date: Thu, 12 Aug 2010 22:56:27 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On Thu, 12 Aug 2010, Blue Swirl wrote: > Add a few rules, based loosely on libvirt HACKING. > > Blue Swirl (5): > CODING_STYLE: add preprocessor rules > CODING_STYLE: add C type rules > CODING_STYLE: add memory management rules > CODING_STYLE: add string management rules > CODING_STYLE: add rules for printf-like functions > > CODING_STYLE | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 111 insertions(+), 0 deletions(-) While intentions of this are good, i believe this goes too far, i doubt that the proposed additions are enforcable and have no doubts that they will be widely ignored and at the same time provide more grounds for whining. Furthermore the existing code doesn't follow them, going out on a limb, it's more likely that one would look around the code he/she modifies and base his/her modifications on the surrounding code than to follow the style that conflicts with it. -- mailto:av1474@comtv.ru