qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, "Jürgen Lock" <nox@jelal.kn-bremen.de>
Subject: [Qemu-devel] Re: [PATCH] TCG: Fix Darwin/ppc calling convention recognition
Date: Sun, 15 Aug 2010 00:41:38 +0400 (MSD)	[thread overview]
Message-ID: <alpine.LNX.2.00.1008150041090.1484@linmac> (raw)
In-Reply-To: <1281811910-8824-1-git-send-email-andreas.faerber@web.de>

On Sat, 14 Aug 2010, Andreas F?rber wrote:

> 5da79c86a3744e3a901c7986c109dd06951befd2 broke compilation on Mac OS X 
> v10.5 ppc. Apple's GCC 4.0.1 does not define _CALL_DARWIN. Recognize 
> __APPLE__ again as well.

Thanks. Applied.

> 
> Signed-off-by: Andreas F?rber <andreas.faerber@web.de>
> Cc: malc <av1474@comtv.ru>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: J?rgen Lock <nox@jelal.kn-bremen.de>
> Cc: Stefan Weil <weil@mail.berlios.de>
> ---
>  Been using a similar patch for some time but apparently hadn't posted it yet...
>  Together with one of Cam's KVM-related patches this fixes the build for me.
>  
>  Regards,
>  Andreas
>  
>  tcg/ppc/tcg-target.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h
> index 5302428..a1f8599 100644
> --- a/tcg/ppc/tcg-target.h
> +++ b/tcg/ppc/tcg-target.h
> @@ -65,7 +65,7 @@ enum {
>  /* used for function call generation */
>  #define TCG_REG_CALL_STACK TCG_REG_R1
>  #define TCG_TARGET_STACK_ALIGN 16
> -#if defined _CALL_DARWIN
> +#if defined _CALL_DARWIN || defined __APPLE__
>  #define TCG_TARGET_CALL_STACK_OFFSET 24
>  #elif defined _CALL_AIX
>  #define TCG_TARGET_CALL_STACK_OFFSET 52
> 

-- 
mailto:av1474@comtv.ru

      reply	other threads:[~2010-08-14 20:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14 20:10 [Qemu-devel] [PATCH 0/3] FreeBSD/ppc host patches Juergen Lock
2010-02-14 20:12 ` [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation Juergen Lock
2010-02-15  3:15   ` malc
2010-02-15 22:45     ` Juergen Lock
2010-02-15  3:16   ` malc
2010-02-15 22:40     ` Juergen Lock
2010-02-16  6:52       ` malc
2010-02-16 17:56         ` Juergen Lock
2010-02-16 19:07           ` malc
2010-02-16 19:50             ` [Qemu-devel] " Paolo Bonzini
2010-02-16 20:34               ` Juergen Lock
2010-02-16 21:19                 ` Juergen Lock
2010-02-14 20:12 ` [Qemu-devel] [PATCH 2/3] Add FreeBSD/ppc host ucontext definitions Juergen Lock
2010-02-14 20:13 ` [Qemu-devel] [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions Juergen Lock
2010-02-16 21:14   ` [Qemu-devel] " Juergen Lock
2010-04-06 16:28     ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS, STACK_OFFSET} definitions Andreas Färber
2010-04-06 17:14       ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions malc
2010-04-06 17:19         ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS, STACK_OFFSET} definitions Andreas Färber
2010-04-06 17:44           ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions malc
2010-08-14 18:51             ` [Qemu-devel] [PATCH] TCG: Fix Darwin/ppc calling convention recognition Andreas Färber
2010-08-14 20:41               ` malc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1008150041090.1484@linmac \
    --to=av1474@comtv.ru \
    --cc=andreas.faerber@web.de \
    --cc=nox@jelal.kn-bremen.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).