From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53305 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OkNos-0006mP-DN
	for qemu-devel@nongnu.org; Sat, 14 Aug 2010 16:59:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1OkNon-0002XM-4m
	for qemu-devel@nongnu.org; Sat, 14 Aug 2010 16:59:10 -0400
Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:54482 helo=akado.ru)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1OkNom-0002W7-TY
	for qemu-devel@nongnu.org; Sat, 14 Aug 2010 16:59:05 -0400
Date: Sun, 15 Aug 2010 00:58:39 +0400 (MSD)
From: malc <av1474@comtv.ru>
In-Reply-To: <1281819176-14147-1-git-send-email-andreas.faerber@web.de>
Message-ID: <alpine.LNX.2.00.1008150058300.2007@linmac>
References: <1281819176-14147-1-git-send-email-andreas.faerber@web.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: [Qemu-devel] Re: [PATCH] TCG: Revert ppc64 tcg_out_movi32 change
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On Sat, 14 Aug 2010, Andreas F?rber wrote:

> 3b6dac34161bc0a342336072643c2f6d17e0ec45 apparently broke the ppc64 TCG target
> compilation in the code path without guest base.

Thanks. Applied.

> 
> Reverting this line fixes the build.
> 
> Signed-off-by: Andreas F?rber <andreas.faerber@web.de>
> Cc: malc <av1474@comtv.ru>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/ppc64/tcg-target.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
> index 5ba5d05..ebbee34 100644
> --- a/tcg/ppc64/tcg-target.c
> +++ b/tcg/ppc64/tcg-target.c
> @@ -746,7 +746,7 @@ static void tcg_out_qemu_ld (TCGContext *s, const TCGArg *args, int opc)
>          else tcg_out32 (s, LDX | TAB (data_reg, rbase, r0));
>  #else
>          if (bswap) {
> -            tcg_out_movi32 (s, TCG_TYPE_I64, 0, 4);
> +            tcg_out_movi32 (s, 0, 4);
>              tcg_out32 (s, LWBRX | RT (data_reg) | RB (r0));
>              tcg_out32 (s, LWBRX | RT (      r1) | RA (r0));
>              tcg_out_rld (s, RLDIMI, data_reg, r1, 32, 0);
> 

-- 
mailto:av1474@comtv.ru