From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33776 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Om7BU-0002id-02
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:37:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1Om7BS-0000QE-VK
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:37:39 -0400
Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:61526 helo=akado.ru)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1Om7BS-0000Pe-P4
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:37:38 -0400
Date: Thu, 19 Aug 2010 19:36:57 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 8/9] spice: simple display
In-Reply-To: <4C6D4EF4.8020602@codemonkey.ws>
Message-ID: <alpine.LNX.2.00.1008191935160.5661@linmac>
References: <1282221625-29501-1-git-send-email-kraxel@redhat.com>
	<1282221625-29501-9-git-send-email-kraxel@redhat.com>
	<4C6D4221.8080504@codemonkey.ws>
	<alpine.LNX.2.00.1008191922390.5362@linmac>
	<4C6D4EF4.8020602@codemonkey.ws>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Thu, 19 Aug 2010, Anthony Liguori wrote:

> On 08/19/2010 10:23 AM, malc wrote:
> > 
> > > > +
> > > > +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy,
> > > > SimpleSpiceUpdate
> > > > *update)
> > > > +{
> > > > +    qemu_free(update->bitmap);
> > > > +    qemu_free(update);
> > > > +}
> > > > +
> > > > +void qemu_spice_create_host_memslot(SimpleSpiceDisplay *ssd)
> > > > +{
> > > > +    QXLDevMemSlot memslot;
> > > > +
> > > > +    if (debug)
> > > > +        fprintf(stderr, "%s:\n", __FUNCTION__);
> > > > 
> > > >        
> > > a dprintf() would better fit qemu's style.
> > >      
> > A dprintf is a POSIX function.
> >    
> 
> Apparently a recent POSIX function...
> 
> Preferred alternatives?  I really dislike all caps macros.

Macros should be all capps.

[..snip..]

-- 
mailto:av1474@comtv.ru