qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
	Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Sun, 22 Aug 2010 22:39:11 +0400 (MSD)	[thread overview]
Message-ID: <alpine.LNX.2.00.1008222238010.3965@linmac> (raw)
In-Reply-To: <AANLkTi=_1pe53y=ZWYo-PVVzFcaYqm-2U2tpY8gg-YTD@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2866 bytes --]

On Sun, 22 Aug 2010, Blue Swirl wrote:

> On Sun, Aug 22, 2010 at 4:40 PM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> > On 08/21/10 12:47, Blue Swirl wrote:
> >> On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster <armbru@redhat.com> wrote:
> >>> Unless you mass-convert existing code to your style, tools working on
> >>> source files won't cut it, because reports of the patch's style
> >>> violations are prone to drown in a sea of reports of preexisting style
> >>> violations.  There's a reason why Linux's scrtips/checkpatch.pl works on
> >>> patch files.
> >>
> >> Mass conversion would have the benefit that submitters, who use old
> >> code as their reference, are more likely to use the correct style.
> >
> > Problem with mass conversion is that it becomes really hard to track
> > changes for debugging. While it would be nice to get all code to look
> > the 'right way<tm>' in a snap, then I think it will cause more harm than
> > good.
> 
> Well, consider for example mass braces conversion to the One Style,
> whichever that is. Would it be better to do it in one commit or
> multiple commits? If the latter, push all commits back-to-back or just
> one at a time now and then?
> 
> At the extreme end, we could even convert one statement per commit.
> This would make bug hunting with git bisect extremely precise. There
> would be a cost of long commit log.
> 
> For the patch submitters, wouldn't one shot conversion (with one push,
> one or many commits) be less painful?
> 
> >>> I still think inventing yet another idiosyncratic coding style plus
> >>> tools to enforce it is a waste of time.
> >>
> >> There are historical reasons for the style used in the current code
> >> base. There are also reasons why CODING_STYLE was written like it
> >> stands now.
> >
> > Yes, it's a classic case, there is always the historical side and
> > personal bios for why it was written the way it is. Often this is goes
> > back to personal preference rather than reason :( IMHO it isn't such a
> > big issue what the style is, as long as it is consistent and efficient.
> > The problem with the style we have now is that is is totally
> > inconsistent
> 
> Fully agree.
> 
> > and has elements making it harder to debug the code, like
> > the braces around single line if statements.
> 
> What's the problem?

Disregarding my own stance on the braces, braces around single statement
is actually helpful w.r.t. debugging imaging trying to set a break point
on said singlesttement, plain impossible in following case:

if (a) b;

> 
> > I totally agree with Markus
> > that it seems like wasted effort to come up with new tools and having to
> > maintain them when there are good ones out there like the ones from the
> > Linux kernel.
> 
> I also find the tool argument very attractive. No other style has that 
> benefit.
> 

-- 
mailto:av1474@comtv.ru

  reply	other threads:[~2010-08-22 18:39 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 17:49 [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Blue Swirl
2010-08-12 18:56 ` malc
2010-08-13 15:22   ` Miguel Di Ciurcio Filho
2010-08-13 18:02     ` Blue Swirl
2010-08-17  8:04       ` Jes Sorensen
2010-08-17 13:21         ` Anthony Liguori
2010-08-17 13:55           ` Jes Sorensen
2010-08-17 18:56             ` Blue Swirl
2010-08-19 13:32               ` Jes Sorensen
2010-08-19 18:29                 ` Blue Swirl
2010-08-22 20:15                   ` Avi Kivity
2010-08-22 20:20                     ` Jes Sorensen
2010-08-22 20:36                       ` Avi Kivity
2010-08-20 13:47           ` Markus Armbruster
2010-08-20 18:44             ` Blue Swirl
2010-08-20 20:24               ` Blue Swirl
2010-08-21  9:54                 ` Markus Armbruster
2010-08-21 10:47                   ` Blue Swirl
2010-08-21 12:24                     ` Markus Armbruster
2010-08-21 14:03                       ` Blue Swirl
2010-08-22 16:49                         ` Jes Sorensen
2010-08-22 17:00                           ` malc
2010-08-22 18:32                             ` Blue Swirl
2010-08-22 18:35                               ` malc
2010-08-23  8:02                                 ` Jes Sorensen
2010-08-23 14:07                                   ` john cooper
2010-08-22 18:18                           ` Blue Swirl
2010-08-22 18:36                             ` malc
2010-08-22 18:42                               ` Anthony Liguori
2010-08-22 20:03                                 ` Avi Kivity
2010-08-23  8:33                                 ` Kevin Wolf
2010-08-23 13:52                                 ` Jes Sorensen
2010-08-24 12:34                                 ` Markus Armbruster
2010-08-22 18:41                           ` Anthony Liguori
2010-08-22 18:56                             ` Blue Swirl
2010-08-22 19:28                               ` Anthony Liguori
2010-08-22 19:44                                 ` malc
2010-08-22 19:50                                   ` Blue Swirl
2010-08-22 20:28                                     ` malc
2010-08-22 20:39                                   ` Avi Kivity
2010-08-23 13:55                                     ` Jes Sorensen
2010-08-23 14:03                                       ` Avi Kivity
2010-08-23 14:07                                         ` Jes Sorensen
2010-08-23 14:15                                           ` Avi Kivity
2010-08-22 19:47                                 ` Blue Swirl
2010-08-22 20:09                               ` Avi Kivity
2010-08-22 20:15                                 ` Blue Swirl
2010-08-22 20:17                                 ` Anthony Liguori
2010-08-22 20:41                                   ` Avi Kivity
2010-08-23  7:17                               ` [Qemu-devel] " Paolo Bonzini
2010-08-22 16:40                     ` [Qemu-devel] " Jes Sorensen
2010-08-22 18:13                       ` Blue Swirl
2010-08-22 18:39                         ` malc [this message]
2010-08-23  8:14                           ` Jes Sorensen
2010-08-23 14:04                             ` john cooper
2010-08-23  8:09                         ` Jes Sorensen
2010-08-22 20:12                       ` Avi Kivity
2010-08-22 20:16                         ` Blue Swirl
2010-08-22 20:43                           ` Avi Kivity
2010-08-23 11:01                         ` Markus Armbruster
2010-08-23 11:07                           ` Avi Kivity
2010-08-17 18:51         ` Blue Swirl
2010-08-13 17:52   ` Blue Swirl
2010-08-13 20:54     ` malc
2010-08-15 14:04   ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1008222238010.3965@linmac \
    --to=av1474@comtv.ru \
    --cc=Jes.Sorensen@redhat.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).