From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34528 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnH1g-00043V-Ob
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:20:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1OnGTG-0004uB-Aw
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:44:47 -0400
Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:63415 helo=akado.ru)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <av1474@comtv.ru>) id 1OnGTG-0004u1-3Q
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:44:46 -0400
Date: Sun, 22 Aug 2010 23:44:37 +0400 (MSD)
From: malc <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
In-Reply-To: <4C717A6C.9080805@codemonkey.ws>
Message-ID: <alpine.LNX.2.00.1008222341190.4325@linmac>
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>
	<alpine.LNX.2.00.1008122251300.1975@linmac>
	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>
	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>
	<4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws>
	<m3vd75flas.fsf@blackfin.pond.sub.org>
	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>
	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>
	<m3eidsxpdo.fsf@blackfin.pond.sub.org>
	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>
	<m3bp8wp30w.fsf@blackfin.pond.sub.org>
	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>
	<4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws>
	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>
	<4C717A6C.9080805@codemonkey.ws>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Sun, 22 Aug 2010, Anthony Liguori wrote:

> On 08/22/2010 01:56 PM, Blue Swirl wrote:
> > > Why is this even still being discussed?  What problem are people actually
> > > trying to solve?
> > > 
> > > Can someone point to a bug in QEMU that's been caused because of
> > > CODING_STYLE or the fact that some patches don't adhere to it?
> > >      
> > 7b1df88f284f462ecb236931ad863a815f243195
> >    
> 
> That's a hell of a bug :-)
> 
> > > I don't see a problem with the way things are today.
> > >      
> > There is the problem that some patch submitters are reminded of
> > CODING_STYLE while others aren't.
> 
> I still think we spend far too much time discussing this on list.  While I
> stand corrected that we've ever had a bug because of this, I have a hard time
> believing this is anywhere in the top 10 list of issues that we have.

You don't.

if (len != 4) {
   /* TODO: Signal an error? */
}

Is just as affected and follows the style perfectly.

> 
> Regards,
> 
> Anthony Liguori
> 
> >   Some don't need to be reminded but
> > they are not part of the problem.
> >    

You weirdly snipped that part, here it is in full:

 
> There is the problem that some patch submitters are reminded of
> CODING_STYLE while others aren't. Some don't need to be reminded but
> they are not part of the problem.

And to this i fully subscribe. 

-- 
mailto:av1474@comtv.ru