From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48015 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnH9b-0008U0-HJ for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:28:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnH9a-0000vn-E9 for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:28:31 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:63256 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnH9a-0000vd-61 for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:28:30 -0400 Date: Mon, 23 Aug 2010 00:28:18 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments In-Reply-To: Message-ID: References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws> <4C717A6C.9080805@codemonkey.ws> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="33734824-467100893-1282508904=:4666" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Jes Sorensen , Miguel Di Ciurcio Filho , Markus Armbruster , qemu-devel This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --33734824-467100893-1282508904=:4666 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 22 Aug 2010, Blue Swirl wrote: > On Sun, Aug 22, 2010 at 7:44 PM, malc wrote: > > On Sun, 22 Aug 2010, Anthony Liguori wrote: > > > >> On 08/22/2010 01:56 PM, Blue Swirl wrote: > >> > > Why is this even still being discussed?  What problem are people actually > >> > > trying to solve? > >> > > > >> > > Can someone point to a bug in QEMU that's been caused because of > >> > > CODING_STYLE or the fact that some patches don't adhere to it? > >> > > > >> > 7b1df88f284f462ecb236931ad863a815f243195 > >> > > >> > >> That's a hell of a bug :-) > >> > >> > > I don't see a problem with the way things are today. > >> > > > >> > There is the problem that some patch submitters are reminded of > >> > CODING_STYLE while others aren't. > >> > >> I still think we spend far too much time discussing this on list.  While I > >> stand corrected that we've ever had a bug because of this, I have a hard time > >> believing this is anywhere in the top 10 list of issues that we have. > > > > You don't. > > > > if (len != 4) { > >   /* TODO: Signal an error? */ > > } > > > > Is just as affected and follows the style perfectly. > > No. I think you missed a very, very important detail in the line with > the comment. The trailing ';'? If so, then no i haven't missed it, i was warned about it ages ago while playing around with clang. if (len != 4); === if (len != 4) {} as far as abstract machine goes. [..snip..] -- mailto:av1474@comtv.ru --33734824-467100893-1282508904=:4666--