Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

[malc <av1474@comtv.ru>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1330 bytes --]

On Thu, 26 Aug 2010, Blue Swirl wrote:

> On Wed, Aug 25, 2010 at 8:46 PM, malc <av1474@comtv.ru> wrote:
> > On Wed, 25 Aug 2010, Blue Swirl wrote:
> >
> >> On Wed, Aug 25, 2010 at 4:33 PM, Andreas Niederl
> >> <andreas.niederl@iaik.tugraz.at> wrote:
> >> > This implementation is based on the TPM 1.2 interface for virtualized TPM
> >> > devices from the Xen-4.0.0 ioemu-qemu-xen fork.
> >> >

[..snip..]

> >> There's hw_error() and errx(), no need to reinvent the wheel.
> >
> > Since it looks as if this code was based on mine, i take issues with
> > your analysis.
> >
> > Firstly hw_error is for hardware errors and does not print message
> > corresponding to errno code
> 
> Right, the correct function should be error_report().

Which is not at all the same as err/errx or die/die2 (doesn't abort/exit)

[FWIW die/die2 predates error_report, furthermore error_report kind of
breaks the convention that public functions/helpers have a qemu_ prefix]

> 
> > and lastly there is no errx[1]
> >
> > [..snip..]
> >
> > [1] err(3):
> >    CONFORMING TO
> >       These functions are non-standard BSD extensions.
> 
> err() and errx() are already used somewhere. But these should be
> converted to error_report etc., like other printf based local
> functions.
> 

Only in Linux specific nbd code.

-- 
mailto:av1474@comtv.ru