From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42458 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P3uVo-0004pp-ST for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P3uVm-0006JL-NZ for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:44:12 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:62139 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P3uVm-0006Io-8l for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:44:10 -0400 Date: Thu, 7 Oct 2010 21:44:06 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable In-Reply-To: Message-ID: References: <4CAD7657.8080400@redhat.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="33734824-512278187-1286473447=:5321" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , qemu-devel This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --33734824-512278187-1286473447=:5321 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 7 Oct 2010, Blue Swirl wrote: > On Thu, Oct 7, 2010 at 8:27 AM, malc wrote: > > On Thu, 7 Oct 2010, Paolo Bonzini wrote: > > > >> On 10/06/2010 11:34 PM, Blue Swirl wrote: > >> > Compiling with GCC 4.6.0 20100925 produced warnings: > >> > /src/qemu/target-i386/op_helper.c: In function 'switch_tss': > >> > /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' > >> > set but not used [-Werror=unused-but-set-variable] > >> > > >> > Fix by deleting the variable. > >> > >> Again, this warning tells us the emulation is incorrect, so it's wrong to > >> remove it. > >> > > > > http://support.amd.com/us/Processor_TechDocs/24593.pdf > > > > 12.2.5 > > T (Trap) Bit--â– Bit 0 of byte 64h, static field. This bit, when set to1, > > causes a debug exception (#DB) to occur on a task switch. See "Beakpoint > > Instruction (INT3)" page 340 for additional information. > > Yes, I read that before making the patch. But page 340 didn't seem to > give any relevant information. 13.2.4 Breakpoint Instruction (INT3) Is what was referred to apparently. -- mailto:av1474@comtv.ru --33734824-512278187-1286473447=:5321--