From: malc <av1474@comtv.ru>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Adam Litke <agl@us.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files
Date: Wed, 27 Oct 2010 23:22:10 +0400 (MSD) [thread overview]
Message-ID: <alpine.LNX.2.00.1010272321580.9279@linmac> (raw)
In-Reply-To: <1288203550-23698-1-git-send-email-aliguori@us.ibm.com>
On Wed, 27 Oct 2010, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/block.c b/block.c
> index 1a965b2..00b6f21 100644
> --- a/block.c
> +++ b/block.c
> @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
> BlockDriver *back_drv = NULL;
>
> bs->backing_hd = bdrv_new("");
> - path_combine(backing_filename, sizeof(backing_filename),
> - filename, bs->backing_file);
> - if (bs->backing_format[0] != '\0')
> - back_drv = bdrv_find_format(bs->backing_format);
> + back_drv = bdrv_find_protocol(bs->backing_file);
> + if (!back_drv) {
> + path_combine(backing_filename, sizeof(backing_filename),
> + filename, bs->backing_file);
> + if (bs->backing_format[0] != '\0')
> + back_drv = bdrv_find_format(bs->backing_format);
Sigh..
> + } else {
> + pstrcpy(backing_filename, sizeof(backing_filename),
> + bs->backing_file);
> + }
>
> /* backing files always opened read-only */
> back_flags =
>
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-10-27 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 18:19 [Qemu-devel] [PATCH] block: fix the use of protocols in backing files Anthony Liguori
2010-10-27 19:22 ` malc [this message]
2010-10-27 19:42 ` Anthony Liguori
2010-10-28 8:30 ` Stefan Hajnoczi
2010-10-28 8:50 ` Kevin Wolf
2010-10-28 9:35 ` Daniel P. Berrange
2010-10-28 9:45 ` Stefan Hajnoczi
2010-10-28 9:49 ` Kevin Wolf
2010-10-28 9:51 ` Daniel P. Berrange
2010-10-28 14:10 ` Anthony Liguori
2010-11-04 12:54 ` Kevin Wolf
2010-11-04 13:14 ` Anthony Liguori
2010-11-04 13:31 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1010272321580.9279@linmac \
--to=av1474@comtv.ru \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).