From: malc <av1474@comtv.ru>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing.
Date: Tue, 9 Nov 2010 19:16:08 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.00.1011091915390.5178@linmac> (raw)
In-Reply-To: <1289299669-5504-7-git-send-email-kraxel@redhat.com>
On Tue, 9 Nov 2010, Gerd Hoffmann wrote:
> The HDA bus supports up to 15 codecs, with addresses 0 ... 14.
> We get that wrong in two places:
>
> * When handing out addresses we accept address 15 as valid.
> * The bitmasks for two registers (WAKEEN and STATESTS) don't
> have bit 14 set.
>
> This patch fixes it.
>
I have applied and the reverted this one.
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/intel-hda.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/intel-hda.c b/hw/intel-hda.c
> index 5e13dc3..b34b140 100644
> --- a/hw/intel-hda.c
> +++ b/hw/intel-hda.c
> @@ -56,7 +56,7 @@ static int hda_codec_dev_init(DeviceState *qdev, DeviceInfo *base)
> if (dev->cad == -1) {
> dev->cad = bus->next_cad;
> }
> - if (dev->cad > 15)
> + if (dev->cad >= 15)
> return -1;
Since there are no braces here.
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-11-09 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 10:47 [Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 1/6] intel-hda: exit cleanup Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 2/6] hda-audio: " Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 3/6] intel-hda: Honor WAKEEN bits Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 4/6] intel-hda: update irq status on WAKEEN changes Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 5/6] intel-hda: add msi support Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing Gerd Hoffmann
2010-11-09 16:16 ` malc [this message]
2010-11-09 13:58 ` [Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1011091915390.5178@linmac \
--to=av1474@comtv.ru \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).