From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35819 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFqrp-0000l1-6A for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:16:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFqro-0002cd-90 for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:16:17 -0500 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:58922 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFqro-0002cN-2W for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:16:16 -0500 Date: Tue, 9 Nov 2010 19:16:08 +0300 (MSK) From: malc Subject: Re: [Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing. In-Reply-To: <1289299669-5504-7-git-send-email-kraxel@redhat.com> Message-ID: References: <1289299669-5504-1-git-send-email-kraxel@redhat.com> <1289299669-5504-7-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > The HDA bus supports up to 15 codecs, with addresses 0 ... 14. > We get that wrong in two places: > > * When handing out addresses we accept address 15 as valid. > * The bitmasks for two registers (WAKEEN and STATESTS) don't > have bit 14 set. > > This patch fixes it. > I have applied and the reverted this one. > Signed-off-by: Gerd Hoffmann > --- > hw/intel-hda.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/intel-hda.c b/hw/intel-hda.c > index 5e13dc3..b34b140 100644 > --- a/hw/intel-hda.c > +++ b/hw/intel-hda.c > @@ -56,7 +56,7 @@ static int hda_codec_dev_init(DeviceState *qdev, DeviceInfo *base) > if (dev->cad == -1) { > dev->cad = bus->next_cad; > } > - if (dev->cad > 15) > + if (dev->cad >= 15) > return -1; Since there are no braces here. -- mailto:av1474@comtv.ru