From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42651 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFr9K-00084z-Jc for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:34:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFr9J-0006vW-DA for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:34:22 -0500 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:55958 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFr9J-0006v4-6r for qemu-devel@nongnu.org; Tue, 09 Nov 2010 11:34:21 -0500 Date: Tue, 9 Nov 2010 19:34:09 +0300 (MSK) From: malc In-Reply-To: <1289320118-15206-1-git-send-email-kraxel@redhat.com> Message-ID: References: <1289320118-15206-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: [Qemu-devel] Re: [PATCH] intel-hda: fix codec addressing. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, 9 Nov 2010, Gerd Hoffmann wrote: > The HDA bus supports up to 15 codecs, with addresses 0 ... 14. > We get that wrong in two places: > > * When handing out addresses we accept address 15 as valid. > * The bitmasks for two registers (WAKEEN and STATESTS) don't > have bit 14 set. > > This patch fixes it. > > [ v2: codestyle: add braces ] Applied. [..snip..] -- mailto:av1474@comtv.ru