From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60590 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZuOy-0003Qj-GE for qemu-devel@nongnu.org; Mon, 03 Jan 2011 19:05:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZuOx-0001gJ-GQ for qemu-devel@nongnu.org; Mon, 03 Jan 2011 19:05:24 -0500 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:59586 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZuOx-0001gD-7U for qemu-devel@nongnu.org; Mon, 03 Jan 2011 19:05:23 -0500 Date: Tue, 4 Jan 2011 03:05:18 +0300 (MSK) From: malc Subject: Re: [Qemu-devel] [PATCH] noaudio: use audio_pcm_sw_read() in no_read() In-Reply-To: <201101032359.41230.michael@walle.cc> Message-ID: References: <1294094404-20397-1-git-send-email-michael@walle.cc> <201101032359.41230.michael@walle.cc> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Walle Cc: qemu-devel@nongnu.org On Mon, 3 Jan 2011, Michael Walle wrote: > On Mon, 3 Jan 2011, 23:46:34 malc wrote: > > On Mon, 3 Jan 2011, Michael Walle wrote: > > > Instead of returning a self-calculated empty buffer use the proper method > > > supplied by the audio subsystem. This will fix the return value of the > > > no_read() function which otherwise returns too many samples because > > > total_hw_samples_acquired isn't correctly accounted. > > > > What and how is incorrectly accounted? FWIW the audio_pcm_sw_read will > > perform useless resampling/mixing that's why custom code is used. > total_hw_samples_acquired is never incremented (see audio_pcm_sw_read()). As a > result the noaudio driver returns too many bytes per second. > Okay, then the simpler patch should just increment it by amount in "total" variable. -- mailto:av1474@comtv.ru