From: malc <av1474@comtv.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-ppc@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code
Date: Tue, 4 Oct 2011 03:12:43 +0400 (MSD) [thread overview]
Message-ID: <alpine.LNX.2.00.1110040310430.2383@linmac> (raw)
In-Reply-To: <1317674600-19083-3-git-send-email-sw@weilnetz.de>
On Mon, 3 Oct 2011, Stefan Weil wrote:
> qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets
> to initialize the cache before flush_icache_range() is called.
>
> This patch moves the code to tcg/ppc and tcg/ppc64.
> Initialisation is called from tcg_target_init() there.
>
This can't possibly work, since ...
[..snip..]
> static void tcg_target_init(TCGContext *s)
> {
> +#ifdef __linux__
> + ppc_init_cacheline_sizes(envp);
> +#else
envp is not passed to the enclosing function.
> + ppc_init_cacheline_sizes();
> +#endif
> +
> tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffffffff);
> tcg_regset_set32(tcg_target_call_clobber_regs, 0,
> (1 << TCG_REG_R0) |
[..snip..]
--
mailto:av1474@comtv.ru
prev parent reply other threads:[~2011-10-03 23:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 20:43 [Qemu-devel] Clean cache related code which was used only by PPC hosts Stefan Weil
2011-10-03 20:43 ` [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code Stefan Weil
2011-10-03 21:12 ` Stefan Weil
2011-10-04 7:56 ` Peter Maydell
2011-10-05 8:26 ` Stefan Hajnoczi
2011-10-03 20:43 ` [Qemu-devel] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code Stefan Weil
2011-10-03 20:52 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2011-10-03 21:10 ` Stefan Weil
2011-10-03 21:36 ` Alexander Graf
2011-10-03 21:50 ` Scott Wood
2011-10-03 22:06 ` Alexander Graf
2011-10-03 22:07 ` Scott Wood
2011-10-03 22:11 ` Alexander Graf
2011-10-03 21:40 ` Scott Wood
2011-10-03 21:43 ` Alexander Graf
2011-10-03 21:51 ` Scott Wood
2011-10-03 22:03 ` Alexander Graf
2011-10-04 6:06 ` Benjamin Herrenschmidt
2011-10-04 5:55 ` Stefan Weil
2011-10-04 6:29 ` Paolo Bonzini
2011-10-04 8:11 ` Peter Maydell
2011-10-04 15:44 ` Scott Wood
2011-10-03 23:12 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1110040310430.2383@linmac \
--to=av1474@comtv.ru \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).