Re: [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models

[malc <av1474@comtv.ru>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 4303 bytes --]

On Sun, 16 Oct 2011, Blue Swirl wrote:

> Thanks, applied all.
> 
> On Fri, Oct 7, 2011 at 7:19 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > Highlights of this series:
> >  - generic i8259, now part of hwlib
> >  - qdev conversion of i8259
> >  - fix for i8259 poll mode (and removal of PREP hack)
> >
> > The refactoring will also be important to instantiate i8259-kvm devices
> > for in-kernel irqchip acceleration one day.
> >
> > Changes in v2:
> >  - kept PIC irq state update after reset but clarified why this
> >   required and only valid here
> >  - additional fix: Clear ELCR on reset

It's not cleared on reset on real hardware..
http://www.mail-archive.com/qemu-devel@nongnu.org/msg04569.html


> >  - included already posted updates of patch 22 and 23
> >
> > CC: Andreas F?rber <andreas.faerber@web.de>
> >
> > Jan Kiszka (23):
> >  pc: Drop useless test from isa_irq_handler
> >  pc: Generalize ISA IRQs to GSIs
> >  pc: Convert GSIState::i8259_irq into array
> >  pc: Fix and clean up PIC-to-APIC IRQ path
> >  i8259: Remove premature inline function attributes
> >  i8259: Drop obsolete prototypes
> >  i8259: Move pic_set_irq1 after pic_update_irq
> >  i8239: Introduce per-PIC output interrupt
> >  i8259: Do not update IRQ output after spurious pic_poll_read
> >  i8259: Reorder intack in pic_read_irq
> >  i8259: Update IRQ state after reset
> >  i8259: Clear ELCR on reset
> >  i8259: Switch to per-PIC IRQ update
> >  i8259: Fix poll command
> >  i8259: Clean up pic_ioport_read
> >  i8259: PREP: Replace pic_intack_read with pic_read_irq
> >  i8259: Replace PicState::pics_state with master flag
> >  i8259: Eliminate PicState2
> >  qdev: Add HEX8 property
> >  i8259: Convert to qdev
> >  i8259: Fix coding style
> >  monitor: Restrict pic/irq_info to supporting targets
> >  i8259: Move to hw library
> >
> >  Makefile.objs                        |    1 +
> >  Makefile.target                      |    8 +-
> >  default-configs/alpha-softmmu.mak    |    1 +
> >  default-configs/i386-softmmu.mak     |    1 +
> >  default-configs/mips-softmmu.mak     |    1 +
> >  default-configs/mips64-softmmu.mak   |    1 +
> >  default-configs/mips64el-softmmu.mak |    1 +
> >  default-configs/mipsel-softmmu.mak   |    1 +
> >  default-configs/ppc-softmmu.mak      |    1 +
> >  default-configs/ppc64-softmmu.mak    |    1 +
> >  default-configs/ppcemb-softmmu.mak   |    1 +
> >  default-configs/x86_64-softmmu.mak   |    1 +
> >  hw/an5206.c                          |   10 -
> >  hw/apic.c                            |    4 +
> >  hw/arm_pic.c                         |   11 -
> >  hw/cris_pic_cpu.c                    |    6 -
> >  hw/etraxfs.h                         |    1 +
> >  hw/i8259.c                           |  397 ++++++++++++++++++----------------
> >  hw/ioapic.h                          |    7 +
> >  hw/isa.h                             |    2 +
> >  hw/lm32_pic.c                        |    4 +-
> >  hw/lm32_pic.h                        |    3 +
> >  hw/microblaze_pic_cpu.c              |    6 -
> >  hw/pc.c                              |   24 +--
> >  hw/pc.h                              |   29 ++--
> >  hw/pc_piix.c                         |   30 ++--
> >  hw/ppc_prep.c                        |    2 +-
> >  hw/qdev-properties.c                 |   29 +++
> >  hw/qdev.h                            |    3 +
> >  hw/s390-virtio.c                     |   11 -
> >  hw/shix.c                            |   11 -
> >  hw/sun4m.c                           |    4 +-
> >  hw/sun4m.h                           |    4 +
> >  hw/sun4u.c                           |    8 -
> >  hw/xtensa_pic.c                      |   10 -
> >  monitor.c                            |   21 ++
> >  36 files changed, 339 insertions(+), 317 deletions(-)
> >
> > --
> > 1.7.3.4
> >
> >
> 

-- 
mailto:av1474@comtv.ru