* [Qemu-devel] [PATCH] fmodaudio: Remove unused variable 'bits16' (reported by cppcheck)
@ 2011-11-18 17:16 Stefan Weil
2011-11-18 17:56 ` malc
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2011-11-18 17:16 UTC (permalink / raw)
To: malc; +Cc: qemu-trivial, Stefan Weil, qemu-devel
The variable is assigned a value which is never used,
so remove variable and assignment.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
audio/fmodaudio.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/audio/fmodaudio.c b/audio/fmodaudio.c
index c34cf53..fabf84d 100644
--- a/audio/fmodaudio.c
+++ b/audio/fmodaudio.c
@@ -343,7 +343,7 @@ static void fmod_fini_out (HWVoiceOut *hw)
static int fmod_init_out (HWVoiceOut *hw, struct audsettings *as)
{
- int bits16, mode, channel;
+ int mode, channel;
FMODVoiceOut *fmd = (FMODVoiceOut *) hw;
struct audsettings obt_as = *as;
@@ -374,7 +374,6 @@ static int fmod_init_out (HWVoiceOut *hw, struct audsettings *as)
/* FMOD always operates on little endian frames? */
obt_as.endianness = 0;
audio_pcm_init_info (&hw->info, &obt_as);
- bits16 = (mode & FSOUND_16BITS) != 0;
hw->samples = conf.nb_samples;
return 0;
}
@@ -405,7 +404,7 @@ static int fmod_ctl_out (HWVoiceOut *hw, int cmd, ...)
static int fmod_init_in (HWVoiceIn *hw, struct audsettings *as)
{
- int bits16, mode;
+ int mode;
FMODVoiceIn *fmd = (FMODVoiceIn *) hw;
struct audsettings obt_as = *as;
@@ -432,7 +431,6 @@ static int fmod_init_in (HWVoiceIn *hw, struct audsettings *as)
/* FMOD always operates on little endian frames? */
obt_as.endianness = 0;
audio_pcm_init_info (&hw->info, &obt_as);
- bits16 = (mode & FSOUND_16BITS) != 0;
hw->samples = conf.nb_samples;
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] fmodaudio: Remove unused variable 'bits16' (reported by cppcheck)
2011-11-18 17:16 [Qemu-devel] [PATCH] fmodaudio: Remove unused variable 'bits16' (reported by cppcheck) Stefan Weil
@ 2011-11-18 17:56 ` malc
0 siblings, 0 replies; 2+ messages in thread
From: malc @ 2011-11-18 17:56 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Fri, 18 Nov 2011, Stefan Weil wrote:
> The variable is assigned a value which is never used,
> so remove variable and assignment.
>
Applied, thanks.
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-18 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 17:16 [Qemu-devel] [PATCH] fmodaudio: Remove unused variable 'bits16' (reported by cppcheck) Stefan Weil
2011-11-18 17:56 ` malc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).