From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rf8qI-0007Ko-9O for qemu-devel@nongnu.org; Mon, 26 Dec 2011 06:35:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rf8qH-0006y2-3Q for qemu-devel@nongnu.org; Mon, 26 Dec 2011 06:35:46 -0500 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:49434 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rf8qG-0006xo-RW for qemu-devel@nongnu.org; Mon, 26 Dec 2011 06:35:45 -0500 Date: Mon, 26 Dec 2011 15:35:28 +0400 (MSK) From: malc In-Reply-To: <1324893824-13558-4-git-send-email-i.mitsyanko@samsung.com> Message-ID: References: <1324893824-13558-1-git-send-email-i.mitsyanko@samsung.com> <1324893824-13558-4-git-send-email-i.mitsyanko@samsung.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mitsyanko Igor Cc: e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com On Mon, 26 Dec 2011, Mitsyanko Igor wrote: > This patch adds implementation of "SD specification version 2.00" compliant > SD host controller. Also it provides interface to implement SoC-specific > controllers on top of this specification-compliant one. > [..snip..] > + > +void sdhcv2_reset(SDHCv2State *s) > +{ > + unsigned long begin = (unsigned long)s + offsetof(SDHCv2State, sdmasysad); This is wrong, uintptr_t begin = (uintptr_t) &s->sdmasysad; Caveat emptor: i haven't tried to understand what the code tries to accomplish, so maybe there's a way that doesn't involve even the above. [..snip..] -- mailto:av1474@comtv.ru