From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7BAo-0000uM-78 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:44:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7BAi-0004pF-53 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:44:49 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:61452 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7BAh-0004ow-TZ for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:44:44 -0400 Date: Mon, 12 Mar 2012 23:44:41 +0400 (MSK) From: malc In-Reply-To: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> Message-ID: References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= Cc: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Hello, > > This patch series implements client-side audio volume support. This > reduces confusion of guest users when volume control is not effective > (because mixemu is disabled or because client-side is muted and can't be > unmuted by the guest..) > > Instead, the backend is responsible for applying volume giving the guest > control over the full range of the client, and avoiding multiple level > of volume/mute effects. > > Although I was mainly interested in having the Spice audio backend > support, I also added PulseAudio backend support (which unfortunately > requires full-blown API, even after quick discussion with upstream). > I'm okay with this, provided that: a. Pulse/Spice have per connection volume b. Other drivers are not affected c. mixeng is not the default > Marc-Andr? Lureau (11): > audio: add VOICE_VOLUME ctl > audio: don't apply volume effect if backend has VOICE_VOLUME_CAP > audio: use a nominal volume of UINT_MAX > hw/ac97: remove USE_MIXER code > hw/ac97: the volume mask is not only 0x1f > hw/ac97: add support for volume control > audio/spice: add support for volume control > Do not use pa_simple PulseAudio API > configure: pa_simple is not needed anymore > Allow controlling volume with PulseAudio backend > Make mixemu mandatory > > audio/audio.c | 25 +++- > audio/audio_int.h | 6 + > audio/audio_template.h | 2 + > audio/mixeng.c | 6 - > audio/paaudio.c | 452 +++++++++++++++++++++++++++++++++++++++++++----- > audio/spiceaudio.c | 41 +++++ > configure | 14 +-- > hw/ac97.c | 141 ++++++---------- > hw/hda-audio.c | 4 - > 9 files changed, 531 insertions(+), 160 deletions(-) > > -- mailto:av1474@comtv.ru