From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7BTP-00066z-W5 for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7BTJ-0000ch-RR for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:04:03 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:51647 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7BTJ-0000bR-Kc for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:03:57 -0400 Date: Tue, 13 Mar 2012 00:03:54 +0400 (MSK) From: malc In-Reply-To: <1331578211-18232-4-git-send-email-marcandre.lureau@redhat.com> Message-ID: References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> <1331578211-18232-4-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= Cc: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > It's more appropriate to set the maximum value into a fitting integer. > --- > audio/audio.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/audio/audio.c b/audio/audio.c > index bd9237e..06c2384 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -110,8 +110,8 @@ const struct mixeng_volume nominal_volume = { > .r = 1.0, > .l = 1.0, > #else > - .r = 1ULL << 32, > - .l = 1ULL << 32, > + .r = UINT_MAX, > + .l = UINT_MAX, > #endif > }; How's putting UINT_MAX into int64_t more appropriate? UINT_MAX is even one less than one in 32.32 fixpoint... I must be missing something here. -- mailto:av1474@comtv.ru