qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 08/11] Do not use pa_simple PulseAudio API
Date: Tue, 13 Mar 2012 00:05:40 +0400 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.00.1203130004060.4872@linmac> (raw)
In-Reply-To: <1331578211-18232-9-git-send-email-marcandre.lureau@redhat.com>

On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote:

> Unfortunately, pa_simple is a limited API which doesn't let us
> retrieve the associated pa_stream. It is needed to control the volume
> of the stream.
> ---
>  audio/paaudio.c |  356 +++++++++++++++++++++++++++++++++++++++++++++++++------
>  1 files changed, 318 insertions(+), 38 deletions(-)
> 

I can not test this (do not have pulseaudio on any of the boxen) and so
would have to take your word on whether it works..

This patch is also misses some braces.

[..snip..]

-- 
mailto:av1474@comtv.ru

  reply	other threads:[~2012-03-12 20:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 18:50 [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 01/11] audio: add VOICE_VOLUME ctl Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 02/11] audio: don't apply volume effect if backend has VOICE_VOLUME_CAP Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX Marc-André Lureau
2012-03-12 20:03   ` malc
2012-03-12 20:25     ` Marc-André Lureau
2012-03-12 20:29       ` malc
2012-03-12 20:50         ` Marc-André Lureau
2012-03-12 21:00           ` malc
2012-03-12 21:07             ` Marc-André Lureau
2012-03-12 21:11               ` malc
2012-03-12 21:28                 ` Marc-André Lureau
2012-03-12 21:42                   ` malc
2012-03-12 21:46                     ` Marc-André Lureau
2012-03-12 22:52                       ` malc
2012-03-12 23:09                         ` Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 04/11] hw/ac97: remove USE_MIXER code Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 05/11] hw/ac97: the volume mask is not only 0x1f Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 06/11] hw/ac97: add support for volume control Marc-André Lureau
2012-03-12 19:42   ` malc
2012-03-12 18:50 ` [Qemu-devel] [PATCH 07/11] audio/spice: " Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 08/11] Do not use pa_simple PulseAudio API Marc-André Lureau
2012-03-12 20:05   ` malc [this message]
2012-03-12 18:50 ` [Qemu-devel] [PATCH 09/11] configure: pa_simple is not needed anymore Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 10/11] Allow controlling volume with PulseAudio backend Marc-André Lureau
2012-03-12 18:50 ` [Qemu-devel] [PATCH 11/11] Make mixemu mandatory Marc-André Lureau
2012-03-12 19:44 ` [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) malc
2012-03-12 20:35   ` Marc-André Lureau
2012-03-12 20:51     ` malc
2012-03-12 20:59       ` Marc-André Lureau
2012-03-12 21:02         ` malc
2012-03-13 10:19           ` Gerd Hoffmann
2012-03-13 10:33             ` Kevin Wolf
2012-03-13 10:34               ` Gerd Hoffmann
2012-03-13 11:02             ` Marc-André Lureau
2012-03-13 12:09               ` malc
  -- strict thread matches above, loose matches on Subject: below --
2012-03-01 14:27 [Qemu-devel] [PATCH 00/11] apply volume on client side Marc-André Lureau
2011-09-21 16:10 ` [Qemu-devel] [PATCH 00/11] RFC: apply volume on client stream Marc-André Lureau
2012-03-01 14:28   ` [Qemu-devel] [PATCH 08/11] Do not use pa_simple PulseAudio API Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1203130004060.4872@linmac \
    --to=av1474@comtv.ru \
    --cc=dlaor@redhat.com \
    --cc=dnb@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).