From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7CDB-0007ma-OC for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7CDA-0003e8-3k for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:51:21 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:52175 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7CD9-0003do-Ta for qemu-devel@nongnu.org; Mon, 12 Mar 2012 16:51:20 -0400 Date: Tue, 13 Mar 2012 00:51:16 +0400 (MSK) From: malc In-Reply-To: Message-ID: References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= Cc: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Hi Vassili > > Thanks for your review! > > On Mon, Mar 12, 2012 at 8:44 PM, malc wrote: > > a. Pulse/Spice have per connection volume > > Each playback/recorde stream has it's own volume, and that's what we > control. We get the client full range thanks to flat-volume logic > (implemented by PulseAudio and Windows Vista+) Okay. > > > b. Other drivers are not affected > > I don't see yet how, but I will review other drivers ctl_{in,out} > implementations You don't see how they can be affected or you don't see how you can figure that out? > > > c. mixeng is not the default > > So you mean the last patch shouldn't be applied? Can you explain the > rationale? Why would we want broken behaviour by default? > Because i hate change. -- mailto:av1474@comtv.ru