From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7CXW-0003aZ-ER for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7CX6-0000Mq-Vr for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:12:22 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:50358 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7CX6-0000MV-Oc for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:11:56 -0400 Date: Tue, 13 Mar 2012 01:11:53 +0400 (MSK) From: malc In-Reply-To: Message-ID: References: <1331578211-18232-1-git-send-email-marcandre.lureau@redhat.com> <1331578211-18232-4-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= Cc: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= , dnb@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:00 PM, malc wrote: > > I really do not understand your point at all, mixeng_volume fields > > are int64_t's it's irrelevant what you initialize them with, they > > are still 64bit integers, and UINT_MAX as i already said is not even > > correct, it's 1/(2**32-1) less than one in fixed point. > > But the current code does this: > > AUD_set_volume_out (SWVoiceOut *sw, int mute, uint8_t lvol..) > > sw->vol.l = nominal_volume.l * lvol / 255; > > So the range was [0..2^8-1] and then it becomes [0..2^32], which looks > wrong to me. It actually becomes [-2^63..2^63-1] nominal_volume.l being 64 bit signed and all. > > And Spice uses [0..2^16-1]. So it is simpler to stay within the range > of an integer.. I do not get you, i really don't. -- mailto:av1474@comtv.ru