From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9kD9-0006ZG-GD for qemu-devel@nongnu.org; Mon, 19 Mar 2012 17:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9kCp-0001ju-9u for qemu-devel@nongnu.org; Mon, 19 Mar 2012 17:33:51 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:56345 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9kCp-0001f1-2J for qemu-devel@nongnu.org; Mon, 19 Mar 2012 17:33:31 -0400 Date: Tue, 20 Mar 2012 01:33:22 +0400 (MSK) From: malc In-Reply-To: <1332191549-1311-2-git-send-email-sw@weilnetz.de> Message-ID: References: <1332191549-1311-1-git-send-email-sw@weilnetz.de> <1332191549-1311-2-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 2/2] ppc: Use uintptr_t for arguments of ppc_tb_set_jmp_target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , qemu-devel@nongnu.org On Mon, 19 Mar 2012, Stefan Weil wrote: > The previous commit changed function tb_set_jmp_target1 and is needed > for w64 hosts. > > This patch is not needed for w64, but it synchronizes tb_set_jmp_target1 > and ppc_tb_set_jmp_target so that both functions have the same signature. > > Cc: malc > Signed-off-by: Stefan Weil > --- > exec-all.h | 2 +- > tcg/ppc/tcg-target.c | 2 +- > tcg/ppc64/tcg-target.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/exec-all.h b/exec-all.h > index a6d6519..9ffd778 100644 > --- a/exec-all.h > +++ b/exec-all.h > @@ -199,7 +199,7 @@ static inline void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr) > /* no need to flush icache explicitly */ > } > #elif defined(_ARCH_PPC) > -void ppc_tb_set_jmp_target(unsigned long jmp_addr, unsigned long addr); > +void ppc_tb_set_jmp_target(uintptr_t jmp_addr, uintptr_t addr); > #define tb_set_jmp_target1 ppc_tb_set_jmp_target > #elif defined(__i386__) || defined(__x86_64__) > static inline void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr) > diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c > index b0aa914..57000e5 100644 > --- a/tcg/ppc/tcg-target.c > +++ b/tcg/ppc/tcg-target.c > @@ -1305,7 +1305,7 @@ static void tcg_out_brcond2 (TCGContext *s, const TCGArg *args, > tcg_out_bc (s, (BC | BI (7, CR_EQ) | BO_COND_TRUE), args[5]); > } > > -void ppc_tb_set_jmp_target (unsigned long jmp_addr, unsigned long addr) > +void ppc_tb_set_jmp_target (uintptr_t jmp_addr, uintptr_t addr) > { > uint32_t *ptr; > long disp = addr - jmp_addr; This should become intptr_t then.. That said ppc32 code assumes 32bit addresses, and ppc64 tcg_taget_long wide ones.. IOW needs some thinking. > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 409a1ac..c286322 100644 > --- a/tcg/ppc64/tcg-target.c > +++ b/tcg/ppc64/tcg-target.c > @@ -1233,7 +1233,7 @@ static void tcg_out_brcond (TCGContext *s, TCGCond cond, > tcg_out_bc (s, tcg_to_bc[cond], label_index); > } > > -void ppc_tb_set_jmp_target (unsigned long jmp_addr, unsigned long addr) > +void ppc_tb_set_jmp_target (uintptr_t jmp_addr, uintptr_t addr) > { > TCGContext s; > unsigned long patch_size; > -- mailto:av1474@comtv.ru