From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFmIL-00023A-FM for qemu-devel@nongnu.org; Thu, 05 Apr 2012 09:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFmI9-0005Wt-AU for qemu-devel@nongnu.org; Thu, 05 Apr 2012 09:00:07 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:64379 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFmI9-0005WR-3s for qemu-devel@nongnu.org; Thu, 05 Apr 2012 08:59:57 -0400 Date: Thu, 5 Apr 2012 16:59:37 +0400 (MSK) From: malc In-Reply-To: <4F7D9691.9090507@redhat.com> Message-ID: References: <6e10c02cbb87fe30703de848455593df41ec7f4b.1333623555.git.jan.kiszka@siemens.com> <4F7D887B.1030104@siemens.com> <4F7D921E.9040003@redhat.com> <4F7D9691.9090507@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH v3 01/10] Introduce qemu_cond_timedwait for POSIX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Jan Kiszka , Anthony Liguori , "qemu-devel@nongnu.org" , Peter Maydell On Thu, 5 Apr 2012, Paolo Bonzini wrote: > Il 05/04/2012 14:53, malc ha scritto: > > On Thu, 5 Apr 2012, Paolo Bonzini wrote: > > > >> Il 05/04/2012 14:30, malc ha scritto: > >>>>> Would save that "* 1000". I just wondered why we do not use it elsewhere > >>>>> in QEMU and was reluctant to risk some BSD breakage. > >>>>> > >>> It's probably worth mentioning that using anything other than > >>> clock_gettime and CLOCK_MONOTONING (as well as setting proper pthread > >>> clock attr on the condition variable) is prone to the surprises (such > >>> as NTP corrections and daylight saving changes). > >> > >> I was about to suggest the same, but how widespread is support for > >> pthread_condattr_setclock? > > > > If it's not all is lost anyway. > > Only once every year. :) DST changes happen twice if i'm not mistaken, NTP is at liberty to change things more than once at any rate. -- mailto:av1474@comtv.ru