From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQzEa-0006Bu-SK for qemu-devel@nongnu.org; Sun, 06 May 2012 07:02:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQzEY-0003ZO-PJ for qemu-devel@nongnu.org; Sun, 06 May 2012 07:02:36 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:62898 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQzEY-0003Yz-Cu for qemu-devel@nongnu.org; Sun, 06 May 2012 07:02:34 -0400 Date: Sun, 6 May 2012 15:02:29 +0400 (MSK) From: malc In-Reply-To: Message-ID: References: <4FA325BD.40201@codemonkey.ws> <4FA32BE2.1030401@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , qemu-devel@nongnu.org, Markus Armbruster , Alexander Graf , Anthony Liguori , =?ISO-8859-15?Q?Andreas_F=E4rber?= On Sun, 6 May 2012, Blue Swirl wrote: > On Sun, May 6, 2012 at 10:17 AM, malc wrote: > > On Sun, 6 May 2012, Blue Swirl wrote: > > > >> On Sun, May 6, 2012 at 9:46 AM, malc wrote: > >> > On Sun, 6 May 2012, Blue Swirl wrote: > >> > > >> >> On Sun, May 6, 2012 at 9:03 AM, malc wrote: > >> >> > On Sun, 6 May 2012, Blue Swirl wrote: > >> >> > [..snip..] > >> > >> The same approach worked fine on x86. I don't know all architectures > >> and their ABIs, so I can't fix all back ends. You should be able to do > >> this much better. Is fixing the register order that hard? > > > > Yet you commit broken code without consulting the person who does know > > it, that's the gist of the matter. > > It was not broken code. Did anyone report problems during these months > until now? We need a bug fix, not violent disabling acts. Yes, Alexander told me, that's how i became aware of the issue. > > > > >> > >> > > >> >> > >> >> >> according to ABI and this shouldn't be much different to what was > >> >> >> already in. > >> >> > > >> >> > The code that was commited was > >> >> > a. Pathetically inneficient everywhere > >> >> > b. Wrong for SysV ABI > >> >> > >> >> Yes, that's what I told back then. There are too many ABIs for various > >> >> architectures, the maintainers should know these much better. > >> > > >> > Told whom? > >> > >> The list at least, there were plenty of people involved in the discussions. > > > > Myself excluded for whatever reason. > > Are you not subscribed to the list? And what do rethorical questions have to do with it? Next thing you will demand that i thoroughly study every mail even when not CC-ed or something? > > > > >> > >> > > >> >> > >> >> > > >> >> >> > >> >> >> I have sent out AREG0 patches for ARM and PPC, also I have x86 patches > >> >> >> in preparation. When (if) these and maybe further conversions are > >> >> >> committed for 1.2, PPC host support will be practically nonexistent. > >> >> >> Is this what you want? > >> >> > > >> >> > What i do not want is code that doesn't work. And i take non-existant > >> >> > over wrong any day. I also would prefer to be notified when code which > >> >> > i maintain is modified. > >> >> > >> >> But your approach is not OK in any sense, now we have a failed build. > >> >> Before, we had code that could work in some cases and the other cases > >> >> could be probably easily fixed. > >> >> > >> > > >> > Well, here's a "sense", code that _silently_ misbehaves is NOT "OK". > >> > >> Then fix the misbehaviour instead of this error approach, please. > >> > > > > Please do read your e-mail, in particular messages from Andreas. > > Which messages? This one http://www.mail-archive.com/qemu-devel@nongnu.org/msg110283.html [..snip..] -- mailto:av1474@comtv.ru