From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <av1474@comtv.ru>) id 1SSCde-00087H-Ba
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:33:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <av1474@comtv.ru>) id 1SSCdb-0003sh-Au
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:33:29 -0400
Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:58470 helo=akado.ru)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <av1474@comtv.ru>) id 1SSCda-0003ru-HY
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:33:27 -0400
Date: Wed, 9 May 2012 23:33:16 +0400 (MSK)
From: malc <av1474@comtv.ru>
In-Reply-To: <4FAAC526.5060406@siemens.com>
Message-ID: <alpine.LNX.2.00.1205092333040.3538@linmac>
References: <4FA2D4C8.7010007@siemens.com>
	<alpine.LNX.2.00.1205032332230.3296@linmac>
	<4FA2E46B.4070609@siemens.com>
	<alpine.LNX.2.00.1205040350530.4470@linmac>
	<4FAAC526.5060406@siemens.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, 9 May 2012, Jan Kiszka wrote:

> On 2012-05-03 20:51, malc wrote:
> > On Thu, 3 May 2012, Jan Kiszka wrote:
> > 
> >> On 2012-05-03 16:32, malc wrote:
> >>> On Thu, 3 May 2012, Jan Kiszka wrote:
> >>>
> >>>> Not only clean up enabled voices but any registered one. Backends like
> >>>> pulsaudio rely on unconditional fini handler invocations.
> >>>>
> >>>> This fixes "Memory pool destroyed but not all memory blocks freed!"
> >>>> warnings on VM shutdowns when pa is used.
> >>>
> >>> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?
> >>
> >> This might be some additional issue (that pa is not supporting
> >> enable/disable). In any case, it is unrelated to this one: fini
> >> corresponds to init. And as we initialized the voice, we also have to
> >> finalize it on shutdown. That's what this patch is fixing.
> >>
> > 
> > The issue is that i don't remember exactly why it iterates only over
> > enabled voices, maybe there was a reason, maybe there wasn't, need to
> > think it over. 
> 
> Any news on this?
> 

Nope.

-- 
mailto:av1474@comtv.ru