From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PBA-0007E5-1r for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6PB8-0001JH-Im for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:15 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:58386 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PB8-0001Ix-B7 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:02:14 -0400 Date: Tue, 28 Aug 2012 21:02:05 +0400 (MSK) From: malc In-Reply-To: <20120828154626.GD2903@redhat.com> Message-ID: References: <246329d9a275f3735aeaeab9326b1527330fe13a.1346069810.git.mst@redhat.com> <20120827190636.GC13049@redhat.com> <20120827192452.GE13049@redhat.com> <20120828154626.GD2903@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: gleb@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, Blue Swirl , Jan Kiszka , avi@redhat.com, Anthony Liguori On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:40:56PM +0000, Blue Swirl wrote: > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:12:27PM +0000, Blue Swirl wrote: > > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: > > >> > On Mon, Aug 27, 2012 at 06:58:29PM +0000, Blue Swirl wrote: > > >> >> On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: > > >> >> > In preparation for adding PV EOI support, disable PV EOI by default for > > >> >> > 1.1 and older machine types, to avoid CPUID changing during migration. > > >> >> > > > >> >> > PV EOI can still be enabled/disabled by specifying it explicitly. > > >> >> > Enable for 1.1 > > >> >> > -M pc-1.1 -cpu kvm64,+kvm_pv_eoi > > >> >> > Disable for 1.2 > > >> >> > -M pc-1.2 -cpu kvm64,-kvm_pv_eoi > > >> >> > > > >> >> > Signed-off-by: Michael S. Tsirkin > > >> >> > --- > > >> >> > hw/Makefile.objs | 2 +- > > >> >> > hw/cpu_flags.c | 32 ++++++++++++++++++++++++++++++++ > > >> >> > hw/cpu_flags.h | 9 +++++++++ > > >> >> > hw/pc_piix.c | 2 ++ [..snip..] > > > > No leading underscores. They are not used in QEMU. > > They are *widely* used in QEMU to mark internal > stuff. E.g. parameters in many macros. > ISO/IEC 9899:TC3 7.1.3#1 - All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use. IOW no __ or _[A-Z] at all. - All identifiers that begin with an underscore are always reserved for use as identifiers with file scope in both the ordinary and tag name spaces. IOW _ as the name of an argument to a macro is (probably) okay. > In reality __ is also widely used. I'm still mulling > removing 2.4 from HACKING - it appears too draconian, > the chances of a conflict with preprocessor are remote > and if it triggers, it's trivial to catch. > We also have lots of existing code violating this rule. > > And the rule about _t suffix is just silly. http://pubs.opengroup.org/onlinepubs/7908799/xns/namespace.html [..snip..] -- mailto:av1474@comtv.ru