Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

[malc <av1474@comtv.ru>]

On Tue, 18 Sep 2012, Aurelien Jarno wrote:

> On Tue, Sep 18, 2012 at 07:23:55AM -0700, Richard Henderson wrote:
> > As recently discussed, with the optional fallback to setcond.
> > 
> > I include a patch to target-alpha to test correctness both
> > before and after implementing the opcode in the i386 backend,
> > as well as in the optimizations.
> > 
> 
> Thanks for this new implementation, it's a lot cleaner than the previous
> one, especially the fallback to setcond if not implemented, and the
> argument alias for the x86 backend, deferring the issue to the register
> allocator instead of trying to do that in the backend.
> 
> >From my side, I am ok with it. That said I'd also like to have at least
> the opinion of Malc and Blue (Cc:ed). Comments from others are also
> welcome.

I don't have objections (philosphical or otherwise) to this, the only
request is for a detailed directions on how to exercise non emulated
version (i.e. where to get the alpha image from how to run it exactly)

[..snip..]

P.S. The only thing i've noticed is somewhat unusual naming convention
     in the README, nothing else uses cN and vN naming of arguments,
     perhaps sticking to t0, t1, t2, t3 is better to avoid confusion?

-- 
mailto:av1474@comtv.ru