From: Finn Thain <fthain@telegraphics.com.au>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine
Date: Tue, 16 Jun 2020 20:24:37 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2006162015310.11@nippy.intranet> (raw)
In-Reply-To: <20200614142840.10245-1-mark.cave-ayland@ilande.co.uk>
Tested-by: Finn Thain <fthain@telegraphics.com.au>
Thanks for all your work on this.
I've just noticed a discrepancy between the traces from an ADB bus scan on
Laurent's Apple Quadra and an ADB bus scan on your patched QEMU machine.
Apple Q800:
[C1f][s ][Rff-][Rff ][rff-]
[C2f][s ][R61 ][R05 ][r00-]
[C3f][s ][R79 ][R01 ][r00-]
[C4f][s ][Rff-][Rff ][rff-]
[C5f][s ][Rff-][Rff ][rff-]
[C6f][s ][Rff-][Rff ][rff-]
[C7f][s ][Rff-][Rff ][rff-]
[C8f][s ][Rff-][Rff ][rff-]
[C9f][s ][Rff-][Rff ][rff-]
[Caf][s ][Rff-][Rff ][rff-]
[Cbf][s ][Rff-][Rff ][rff-]
[Ccf][s ][Rff-][Rff ][rff-]
[Cdf][s ][Rff-][Rff ][rff-]
[Cef][s ][Rff-][Rff ][rff-]
[Cff][s ][Rff-][Rff ][rff-]
QEMU Q800:
[C1f][s ][Rff-][Rff ][rff-]
[C2f][s ][R02 ][R01 ][r00-]
[C3f][s ][R03 ][R02 ][r00-]
[C4f][s ][R03-][R02 ][rff-]
[C5f][s ][R03-][R02 ][rff-]
[C6f][s ][R03-][R02 ][rff-]
[C7f][s ][R03-][R02 ][rff-]
[C8f][s ][R03-][R02 ][rff-]
[C9f][s ][R03-][R02 ][rff-]
[Caf][s ][R03-][R02 ][rff-]
[Cbf][s ][R03-][R02 ][rff-]
[Ccf][s ][R03-][R02 ][rff-]
[Cdf][s ][R03-][R02 ][rff-]
[Cef][s ][R03-][R02 ][rff-]
[Cff][s ][R03-][R02 ][rff-]
I think this could be easy to fix; it's probably just an uninitialized
packet buffer. When you come to submit v2, you may want to look into this.
next prev parent reply other threads:[~2020-06-16 10:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 14:28 [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 01/22] adb: coding style update to fix checkpatch errors Mark Cave-Ayland
2020-06-14 16:49 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 02/22] adb: fix adb-mouse read length and revert disable-reg3-direct-writes workaround Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 03/22] cuda: convert ADB autopoll timer from ns to ms Mark Cave-Ayland
2020-06-14 16:50 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 04/22] pmu: fix duplicate autopoll mask variable Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 05/22] pmu: honour autopoll_rate_ms when rearming the ADB autopoll timer Mark Cave-Ayland
2020-06-14 16:50 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 06/22] adb: introduce realize/unrealize and VMStateDescription for ADB bus Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 07/22] adb: create autopoll variables directly within ADBBusState Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 08/22] cuda: convert to use ADBBusState internal autopoll variables Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 09/22] pmu: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 10/22] mac_via: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 11/22] adb: introduce new ADBDeviceHasData method to ADBDeviceClass Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 12/22] adb: keep track of devices with pending data Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 13/22] adb: add status field for holding information about the last ADB request Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 14/22] adb: use adb_request() only for explicit requests Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 15/22] adb: add autopoll_blocked variable to block autopoll Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 16/22] cuda: add adb_autopoll_block() and adb_autopoll_unblock() functions Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 17/22] pmu: " Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 18/22] mac_via: move VIA1 portB write logic into mos6522_q800_via1_write() Mark Cave-Ayland
2020-06-14 17:03 ` Philippe Mathieu-Daudé
2020-06-14 14:28 ` [PATCH 19/22] mac_via: rework ADB state machine to be compatible with both MacOS and Linux Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 20/22] adb: only call autopoll callbacks when autopoll is not blocked Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 21/22] adb: use adb_device prefix for ADB device trace events Mark Cave-Ayland
2020-06-14 17:20 ` Philippe Mathieu-Daudé
2020-06-20 12:01 ` Mark Cave-Ayland
2020-06-14 14:28 ` [PATCH 22/22] adb: add ADB bus " Mark Cave-Ayland
2020-06-14 17:16 ` Philippe Mathieu-Daudé
2020-06-20 11:59 ` Mark Cave-Ayland
2020-06-16 10:24 ` Finn Thain [this message]
2020-06-20 12:10 ` [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2006162015310.11@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).