From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNobL-0008CT-4I for qemu-devel@nongnu.org; Wed, 12 Mar 2014 15:14:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNobG-00050e-St for qemu-devel@nongnu.org; Wed, 12 Mar 2014 15:14:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:4803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNobG-00050H-Mm for qemu-devel@nongnu.org; Wed, 12 Mar 2014 15:13:58 -0400 Date: Wed, 12 Mar 2014 13:13:55 -0600 (MDT) From: Keith Busch In-Reply-To: <1394648907-20096-13-git-send-email-afaerber@suse.de> Message-ID: References: <1394648907-20096-1-git-send-email-afaerber@suse.de> <1394648907-20096-13-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1546076781-1394651636=:2885" Subject: Re: [Qemu-devel] [PATCH qom-next v3 12/15] nvme: Permit zero-length block devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Keith Busch , Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1546076781-1394651636=:2885 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 12 Mar 2014, Andreas Färber wrote: > It may not be sensible for normal use cases, but it allows to use > /dev/null in QTest. Thanks! Sounds useful despite not being usable as storage. :) I applied to my nvme tree here: http://git.infradead.org/users/kbusch/qemu-nvme.git It's quite a bit ahead of the upstream on 'nvme features'. I often hear from people in various orgs using this, so might be time I roll it into a pull request. > Signed-off-by: Andreas Färber > --- > hw/block/nvme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 2882ffe..5fd8f89 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -752,8 +752,8 @@ static int nvme_init(PCIDevice *pci_dev) > return -1; > } > > - bs_size = bdrv_getlength(n->conf.bs); > - if (bs_size <= 0) { > + bs_size = bdrv_getlength(n->conf.bs); > + if (bs_size < 0) { > return -1; > } > > -- > 1.8.4.5 > > --8323328-1546076781-1394651636=:2885--