Re: [Qemu-devel] [PATCH qom-next v3 12/15] nvme: Permit zero-length block devices

[Keith Busch <keith.busch@intel.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1779 bytes --]

On Wed, 12 Mar 2014, Andreas Färber wrote:
> Tonight is Hard Freeze for 2.0. If you could also review the matching
> test case http://patchwork.ozlabs.org/patch/329627/ I would put both in
> my pull.

Looks great! I'd apply the new test case, but it won't without the
previous "pvpanic-test" patch in your series.

> I guess you'll need to submit your queue for review first? Hard
> to see in a non-rebased tree.

For sure. I pushed a new rebased branch to my repo so it could be more
easily observed. My first commit below really ought to have been split
into a dozen or so individuals, so my own fault if it fails review for
that or any other reason. I have no concerns about waiting for the next
window if I need to split it up better and fix anything.

A pull request at this point would look like this:

The following changes since commit 750036a848ea913ba6343718ffa70da98f7eef6b:

   Merge remote-tracking branch 'remotes/afaerber/tags/prep-for-upstream' into staging (2014-03-12 17:53:37 +0000)

are available in the git repository at:


   git://git.infradead.org/users/kbusch/qemu-nvme.git v2.0-updates

for you to fetch changes up to 9323763f1b9db24c575a5f8afc13e460a63cac22:

   nvme: Permit zero-length block devices (2014-03-12 13:17:58 -0600)

----------------------------------------------------------------
Andreas Färber (1):
       nvme: Permit zero-length block devices

Keith Busch (4):
       NVMe: Implement remainder from spec
       NVMe: Clear allocated bitmap after format
       NVMe: Use aio flush
       NVMe: completion queue coalescing

  default-configs/pci.mak |    1 +
  hw/block/nvme.c         | 1640 +++++++++++++++++++++++++++++++++++++++++++----
  hw/block/nvme.h         |  114 ++++
  3 files changed, 1621 insertions(+), 134 deletions(-)