From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B5FCC61DC2 for ; Thu, 27 Aug 2026 12:45:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzZTU-0005Du-FT; Thu, 27 Aug 2026 08:44:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzZTS-0005DZ-QM for qemu-devel@nongnu.org; Thu, 27 Aug 2026 08:44:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzZTQ-0007Wf-R8 for qemu-devel@nongnu.org; Thu, 27 Aug 2026 08:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787834691; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=mfHw2pdetaQIPqh1fTW4lFkRSEEEq3b6ru7ePsl2zPk=; b=FYbGEsmiVA9gTNUTT2IBYUvyvOY7iVX4ABgaItGPPIULbHYi4mq2eS0ROhrHM2D/VYgQFz Cnv/PTPTKUbvzBS2uBU6Csq/jJRUDcrLXMZ2FswDNh9TGu6FAlZNcOGMiQFxuaQ3pVZzfn 47hr+ERRzqwmZFXK0XausWV4u8QAouI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-vL4wxRwXNC6Klj1kO6YscQ-1; Thu, 27 Aug 2026 08:43:41 -0400 X-MC-Unique: vL4wxRwXNC6Klj1kO6YscQ-1 X-Mimecast-MFC-AGG-ID: vL4wxRwXNC6Klj1kO6YscQ_1787834619 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B7FF195605B; Thu, 27 Aug 2026 12:43:39 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 70A0A1955F70; Thu, 27 Aug 2026 12:43:35 +0000 (UTC) Date: Thu, 27 Aug 2026 13:43:32 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jamin Lin Cc: =?utf-8?Q?C=C3=A9dric?= Le Goater , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Eric Blake , Markus Armbruster , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:All patches CC here" , "open list:ASPEED BMCs" , Troy Lee Subject: Re: [PATCH v2 4/9] hw/arm/aspeed_ast10x0: Remove obsolete unimplemented SBC mapping Message-ID: References: <20260821032036.1829294-1-jamin_lin@aspeedtech.com> <20260821032036.1829294-5-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260821032036.1829294-5-jamin_lin@aspeedtech.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Aug 21, 2026 at 03:20:42AM +0000, Jamin Lin wrote: > he AST10x0 SoC now implements the SBC device model. However, the s/he/The/ > old unimplemented SBC mapping was left in place. > > Remove the obsolete mapping now that the SBC device is implemented. > > Signed-off-by: Jamin Lin > --- > hw/arm/aspeed_ast10x0.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c > index 93c81195b5..5165dcce59 100644 > --- a/hw/arm/aspeed_ast10x0.c > +++ b/hw/arm/aspeed_ast10x0.c > @@ -163,8 +163,6 @@ static void aspeed_soc_ast10x0_init(Object *obj, const char *socname) > object_initialize_child(obj, "hace", &s->hace, typename); > > object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DEVICE); > - object_initialize_child(obj, "sbc-unimplemented", &s->sbc_unimplemented, > - TYPE_UNIMPLEMENTED_DEVICE); > object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE); > object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVICE); > object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE); > @@ -222,11 +220,6 @@ static bool aspeed_soc_ast10x0_realize(Aspeed10x0SoCState *a, Error **errp) > "aspeed.io", > sc->memmap[ASPEED_DEV_IOMEM], > ASPEED_SOC_IOMEM_SIZE); > - aspeed_mmio_map_unimplemented(s->memory, > - SYS_BUS_DEVICE(&s->sbc_unimplemented), > - "aspeed.sbc", sc->memmap[ASPEED_DEV_SBC], > - 0x40000); > - > /* AST10x0 CPU Core */ > armv7m = DEVICE(&a->armv7m); > qdev_prop_set_uint32(armv7m, "num-irq", 256); > -- > 2.53.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|