From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Ed Maste" <emaste@freebsd.org>,
qemu-block@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>
Subject: Re: [PATCH v2 4/6] drop libxml2 checks since libxml is not actually used (for parallels)
Date: Thu, 20 Jan 2022 14:37:56 +0100 [thread overview]
Message-ID: <b00aee2c-2085-1849-f7d6-cb6d9d7926f6@redhat.com> (raw)
In-Reply-To: <20220120110545.263404-5-f4bug@amsat.org>
On 20/01/2022 12.05, Philippe Mathieu-Daudé wrote:
> From: Michael Tokarev <mjt@tls.msk.ru>
>
> For a long time, we assumed that libxml2 is neecessary for parallels
> block format support (block/parallels*). However, this format actually
> does not use libxml [*]. Since this is the only user of libxml2 in
> while qemu tree, we can drop all libxml2 checks and dependencies too.
s/while/whole/
> It is even more: --enable-parallels configure option was the only
> option which was silently ignored when it's (fake) dependency
> (libxml2) isn't installed.
>
> Drop all mentions of libxml2.
>
> [*] Actually the basis for libxml use were merged in commit 25bfd5a75
> but the implementation was never merged:
> https://lore.kernel.org/qemu-devel/70227bbd-a517-70e9-714f-e6e0ec431be9@openvz.org/
Commit ed279a06c53784 also add a hunk to scripts/checkpatch.pl ... you might
want to remove that now, too.
Thomas
next prev parent reply other threads:[~2022-01-20 20:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 11:05 [PATCH v2 0/6] tests: Refresh lcitool submodule & remove libxml2 Philippe Mathieu-Daudé via
2022-01-20 11:05 ` [PATCH v2 1/6] MAINTAINERS: Cover lcitool submodule with build test / automation Philippe Mathieu-Daudé via
2022-01-20 11:05 ` [PATCH v2 2/6] tests: Refresh lcitool submodule Philippe Mathieu-Daudé via
2022-01-20 11:05 ` [PATCH v2 3/6] tests/lcitool: Install libibumad to cover RDMA on Debian based distros Philippe Mathieu-Daudé via
2022-01-20 11:12 ` Daniel P. Berrangé
2022-01-20 11:05 ` [PATCH v2 4/6] drop libxml2 checks since libxml is not actually used (for parallels) Philippe Mathieu-Daudé via
2022-01-20 13:37 ` Thomas Huth [this message]
2022-01-20 15:33 ` Philippe Mathieu-Daudé via
2022-01-20 11:05 ` [PATCH v2 5/6] tests/lcitool: Remove libxml2 Philippe Mathieu-Daudé via
2022-01-20 11:14 ` Daniel P. Berrangé
2022-01-20 11:18 ` Philippe Mathieu-Daudé via
2022-01-20 11:21 ` Philippe Mathieu-Daudé via
2022-01-20 11:32 ` Daniel P. Berrangé
2022-01-20 11:35 ` Daniel P. Berrangé
2022-01-20 11:15 ` Philippe Mathieu-Daudé via
2022-01-20 11:05 ` [PATCH v2 6/6] tests: Manually remove libxml2 on MSYS2 targets Philippe Mathieu-Daudé via
2022-01-20 11:08 ` Philippe Mathieu-Daudé via
2022-01-20 11:15 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00aee2c-2085-1849-f7d6-cb6d9d7926f6@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=emaste@freebsd.org \
--cc=f4bug@amsat.org \
--cc=luoyonggang@gmail.com \
--cc=lwhsu@freebsd.org \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).