From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btcje-0003Pv-NU for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:43:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btcjd-0007Hy-Mf for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:43:26 -0400 References: <1476106902-27337-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Mon, 10 Oct 2016 10:35:03 -0500 MIME-Version: 1.0 In-Reply-To: <1476106902-27337-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bTjW9et9dkgdTHUb1TvubeBj0fU9gMBAe" Subject: Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bTjW9et9dkgdTHUb1TvubeBj0fU9gMBAe From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH v2] block: Remove "options" indirection from blockdev-add References: <1476106902-27337-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1476106902-27337-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/10/2016 08:41 AM, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level= > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains th= e > real arguments. >=20 > blockdev-add is still experimental and we already made substantial > changes to the API recently, so we're free to make changes like this > one, too. >=20 > Signed-off-by: Kevin Wolf > --- >=20 > v2: > - Updated some documentation in docs/qmp-commands.txt and > qapi/block-core.json [Max] Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bTjW9et9dkgdTHUb1TvubeBj0fU9gMBAe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX+7UnAAoJEKeha0olJ0Nq3d0H/1uOq9tWMUK64BdPT9FQdT3z 4TbVHn/s7VF6l1VsLIfW+0s6I7dr/7IW805IYm9CFXbXCpYmEwgQuTfKfx5RV3dU y0SI7EXicxjoKHoQNSmw8WYkU1LbKNBF2mfLi14PXP/+r/y4ycw/QtQPLeTQv898 5MTAM3+W1eAeGHGtsUA1XG/IfH4rljb/JXi2uyoh270PJNaerDElw5ajIEKx4K04 SvN+/kT1ojtgVYmPJe3rlFaKVcEYSlmCml3Q/naAwNEe2ztlDI4jqtQ9iRF2t0Lh YKCFNyRH7YJCmtuN92nYFMjg+NHX66Na+NlzpCmjnrVbhTgAAuI88LAsmv1PH2w= =yjoZ -----END PGP SIGNATURE----- --bTjW9et9dkgdTHUb1TvubeBj0fU9gMBAe--