From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0143BC3600C for ; Tue, 8 Apr 2025 06:47:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u22jl-0002T7-Em; Tue, 08 Apr 2025 02:47:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u22jj-0002Mw-AO; Tue, 08 Apr 2025 02:47:07 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76] helo=mail.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u22jh-0005we-29; Tue, 08 Apr 2025 02:47:07 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4ZWxSt2yHFz4x0t; Tue, 8 Apr 2025 16:46:54 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4ZWxSp4kfRz4wcZ; Tue, 8 Apr 2025 16:46:50 +1000 (AEST) Message-ID: Date: Tue, 8 Apr 2025 08:46:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/13] Introduce AST27x0 multi-SoC machine To: Steven Lee , Peter Maydell , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" Cc: Troy Lee , Yunlin Tang References: <20250313054020.2583556-1-steven_lee@aspeedtech.com> <5e3c1b62-2a1c-4e99-8842-d5a06a80d2f1@kaod.org> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=PH2m=W2=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/8/25 08:35, Steven Lee wrote: >> -----Original Message----- >> From: Cédric Le Goater >> Sent: Wednesday, March 26, 2025 1:34 AM >> To: Steven Lee ; Peter Maydell >> ; Troy Lee ; Jamin Lin >> ; Andrew Jeffery >> ; Joel Stanley ; open >> list:ASPEED BMCs ; open list:All patches CC here >> >> Cc: Troy Lee ; Yunlin Tang >> >> Subject: Re: [PATCH v2 00/13] Introduce AST27x0 multi-SoC machine >> >> Hello Steven, >> >> On 3/13/25 06:40, Steven Lee wrote: >>> This patch series introduces full core support for the AST27x0 SoC, along with >> necessary updates to the ASPEED AST27x0 SOC. >>> The AST27x0 SoC is a new family of ASPEED SoCs featuring 4 Cortex-A35 >> cores and 2 Cortex-M4 cores. >>> >>> v1: >>> - Map unimplemented devices in SoC memory >>> - Intruduce AST2700 CM4 SoC >>> - Introduce AST27x0FC Machine >>> >>> v2: >>> - Remove unused functions >>> - Correct hex notation for device addresses in AST27x0 SoC >>> - Add AST2700 SSP INTC and AST2700 TSP INTC >>> - Split AST27x0 CM4 SoC to AST27x0 SSP SoC and AST27x0 TSP SoC >>> - Add AST27x0 A0 SSP SoC and AST27x0 A1 SSP SoC >>> - Add AST27x0 A0 TSP SoC and AST27x0 A1 TSP SoC >>> - Add functional tests for AST2700FC A0 and AST2700FC A1 >>> - Add Documentation for AST2700FC >> >> Please try to label all patches as v2. See 'git format-patch -v ...' >> > > Hi Cédric, > > Thanks for the reminder. I will label the patches as v3 in the next submission. > > Regards, > Steven > >>> Steven Lee (13): >>> aspeed: ast27x0: Map unimplemented devices in SoC memory >>> aspeed: ast27x0: Correct hex notation for device addresses >>> hw/intc/aspeed: Add support for AST2700 SSP INTC >>> hw/intc/aspeed: Add support for AST2700 TSP INTC >>> hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A0 SSP SoC >>> hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A1 SSP SoC >>> hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A0 TSP SoC >>> hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A1 TSP SoC >>> hw/arm: Introduce ASPEED AST2700 a0 full core machine >>> hw/arm: Introduce ASPEED AST2700 a1 full core machine >>> tests/function/aspeed: Add functional test for AST2700FC >>> tests/function/aspeed: Add functional test for AST2700FC A1 >>> docs: Add support for ast2700fc machine >> >> Do we need to add support for the A0 and A1 ? Would A1 be enough ? >> > > I will remove A0 in v3 the patch series. Thanks, it all looked good to me. I should be able to queue the series quickly for QEMU 10.1 before Jamin's HACE changes. C. > >> >> >> >> >>> docs/system/arm/aspeed.rst | 61 ++- >>> include/hw/arm/aspeed_soc.h | 32 ++ >>> include/hw/intc/aspeed_intc.h | 5 + >>> hw/arm/aspeed_ast27x0-fc.c | 340 >> +++++++++++++++++ >>> hw/arm/aspeed_ast27x0-ssp.c | 400 >> +++++++++++++++++++ >>> hw/arm/aspeed_ast27x0-tsp.c | 400 >> +++++++++++++++++++ >>> hw/arm/aspeed_ast27x0.c | 79 +++- >>> hw/intc/aspeed_intc.c | 424 >> +++++++++++++++++++++ >>> hw/arm/meson.build | 6 +- >>> tests/functional/test_aarch64_ast2700fc.py | 161 ++++++++ >>> 10 files changed, 1884 insertions(+), 24 deletions(-) >>> create mode 100644 hw/arm/aspeed_ast27x0-fc.c >>> create mode 100644 hw/arm/aspeed_ast27x0-ssp.c >>> create mode 100644 hw/arm/aspeed_ast27x0-tsp.c >>> create mode 100755 tests/functional/test_aarch64_ast2700fc.py >>> >