From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFEEC433DB for ; Tue, 19 Jan 2021 14:14:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDA822312B for ; Tue, 19 Jan 2021 14:14:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDA822312B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1rm5-0000vA-UB for qemu-devel@archiver.kernel.org; Tue, 19 Jan 2021 09:14:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1rl3-0008Ni-Vm for qemu-devel@nongnu.org; Tue, 19 Jan 2021 09:13:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1rkz-0000SI-9c for qemu-devel@nongnu.org; Tue, 19 Jan 2021 09:13:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611065595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZ+/Dahv4znPl5k32kOuM4zxqHPTgaWLQNqqTZK1mEA=; b=F45tBs7HeQqdsECVTeYjTYUnSfm/N493UaoUmOYzpSLYjRgJwyjdFFQoqwhuxWF1h+YPuU /u0PeWYIF2UhzzNhlhfEXZ+2exbQhmHmLAfXSREWEElEtiWQIjdFJcAQUiAkXjwkB9fUby yYsUsqB2wntjsJfxAR4kUlh3Pz7fkTk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-zrmtWJMNPPOM2FfR9y3RDw-1; Tue, 19 Jan 2021 09:13:14 -0500 X-MC-Unique: zrmtWJMNPPOM2FfR9y3RDw-1 Received: by mail-ed1-f71.google.com with SMTP id f19so9430398edq.20 for ; Tue, 19 Jan 2021 06:13:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UZ+/Dahv4znPl5k32kOuM4zxqHPTgaWLQNqqTZK1mEA=; b=N7L8/JnThFIBjhB8Y8BWsfAPXHoIppUgmqPnVgjPCk3M+hXKgNYqkYJz01iCRk4wFb 0mtsW1o0ZpucJVZ1dw6tfOAeZ7hj381x0CmSVqJPxo6FL5GTMXaLMybKVwUnPhtrekb3 BcRqQyieY7u8umSvPI2BwdrezDlwtGGW0msAQ2ZjPX15LYc7zDtV7DiXOVMPbWlpaom1 QiWlHGQaFmpRswTbw2gV8dypeeUwgg013LWAont86f4Kn9IkmAe3rKm9hCnzOWEyo+eL RnwhbaFpeqlskexRECEAK2nJGt4yuuOBD6h+l5apc5Vmj3u1VSqpdTqYuqOKuge2Y2PS 9zIg== X-Gm-Message-State: AOAM5336tZ0U9b+2yfe+QMuOUriSgAEsxiwdFcIo6O9yRivYEZw4qivg /vrYI8YI+sHwLKAZca1opRtUoASqAcNgMDXz2AZrT6LNoq4QD5hwt/6QIzzTKik6t8euOpRvq8F Crde+7E64gIFL36E= X-Received: by 2002:a17:906:f144:: with SMTP id gw4mr3153970ejb.189.1611065592538; Tue, 19 Jan 2021 06:13:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwErYbMOmLv9Gd1ODPgEWiiXjxb93/W1Hjo2Hx8pQbltYaVYETFcoPcqzH4A4c/pX5mAgOIQ== X-Received: by 2002:a17:906:f144:: with SMTP id gw4mr3153965ejb.189.1611065592413; Tue, 19 Jan 2021 06:13:12 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id i15sm10946432ejj.28.2021.01.19.06.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jan 2021 06:13:11 -0800 (PST) Subject: Re: [PATCH] ide: set an upper limit to nb_sectors To: P J P , Paolo Bonzini References: <20210119134211.494133-1-ppandit@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 19 Jan 2021 15:13:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210119134211.494133-1-ppandit@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.195, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prasad J Pandit , John Snow , QEMU Developers , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Prasad, On 1/19/21 2:42 PM, P J P wrote: > From: Prasad J Pandit > > Set an upper limit to number of sectors on an IDE disk media. > This is to ensure that logical block addresses (LBA) and > nb_sector arguments remain within INT_MAX range. > > Suggested-by: Paolo Bonzini > Signed-off-by: Prasad J Pandit > --- > hw/ide/core.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > Update: limit s->nb_sectors count > -> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg04270.html > -> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg04173.html > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index b49e4cfbc6..064998804a 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -1161,15 +1161,21 @@ static void ide_cfata_metadata_write(IDEState *s) > s->nsector << 9), 0x200 - 2)); > } > > +static void ide_set_nb_sectors(IDEState *s) > +{ > + uint64_t nb_sectors; > + > + blk_get_geometry(s->blk, &nb_sectors); /* An explanation here would be useful */ or better, add a self-explaining definition for this magic value. > + s->nb_sectors = MIN(nb_sectors, (uint64_t)INT_MAX << 2); > +}